Re: [PATCH] slcan2d: add new slcan daemon

[Yegor Yefremov <yegorslists@googlemail.com>]

On Wed, Aug 21, 2013 at 7:46 PM, Oliver Hartkopp <socketcan@hartkopp.net> wrote:
> On 17.08.2013 21:01, Yegor Yefremov wrote:
>> On Wed, Jul 24, 2013 at 2:01 PM, Yegor Yefremov
>> <yegorslists@googlemail.com> wrote:
>>> Hi Marc, Oliver,
>>>
>>> On Thu, Jul 11, 2013 at 11:54 AM,  <yegorslists@googlemail.com> wrote:
>>>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>>>
>>>> Cleaned up version of Oliver Hartkopp's effort with addition of
>>>> UART speed configuration.
>>>>
>>>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>>>
>>> any comments/suggestions?
>>
>> ping
>>
>
> Hi Yegor,
>
> sorry for my delayed response.
>
> I just got through your slcan2d by diffing it with the existing slcand.
>
> It's a cool cleanup and it adds all relevant command line options we know from
> slcan_attach.c & UART settings - i think that was the idea, right?

Yes. slcan_attach.c is almost obsolete now.

> As i can see there's no change of the functionality when the 'optional
> options' are not given on the command line.
>
> So why don't you just post a patch which makes the slcand your 'slcan2d' code?

You're right. I've reposted the patch as slcand with detailed
description, of what has really changed.

> IMHO having both the slcand and the slcan2d in the same repository does not
> make sense if they behave identical when having the same (empty) options.
>
> Or did I miss anything that slcand <tty> behaves different to slcan2d <tty> ??

ACK.

Yegor