public inbox for linux-can@vger.kernel.org
 help / color / mirror / Atom feed
From: "Markus Schneider-Pargmann" <msp@baylibre.com>
To: "Marc Kleine-Budde" <mkl@pengutronix.de>,
	"Kendall Willis" <k-willis@ti.com>
Cc: "Markus Schneider-Pargmann" <msp@baylibre.com>,
	"Vincent Mailhol" <mailhol@kernel.org>, <sebin.francis@ti.com>,
	<d-gole@ti.com>, <vishalm@ti.com>, <linux-can@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] can: m_can: set out-of-band wakeup if wakeup pinctrl exists
Date: Wed, 18 Feb 2026 11:57:03 +0100	[thread overview]
Message-ID: <DGI1850U6GMU.AMN60BPYQ73I@baylibre.com> (raw)
In-Reply-To: <20260217-remarkable-jasmine-sturgeon-3edb31-mkl@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 923 bytes --]

Hi Marc,

On Tue Feb 17, 2026 at 10:08 PM CET, Marc Kleine-Budde wrote:
> On 13.02.2026 12:08:19, Kendall Willis wrote:
>> In TI AM62X, AM62A, and AM62P SoCs, the m_can pins can act as a wakeup
>> source in the deepest low power states. However, the m_can pins are a part
>> of the MCU domain which is OFF in deeper low power states. Since the m_can
>> pins continue to be ON even if the MCU domain is turned off, set
>> out-of-band wakeup for CAN device if `wakeup` pinctrl state exists and
>> device may wakeup.
>>
>> Signed-off-by: Kendall Willis <k-willis@ti.com>
>
> @Markus, can you review the patch?
>
> To both of you: Do we need a fixes tag?

I don't think so. device_out_band_wakeup() was introduced after the
wakeup pinctrl was added to this driver. So I don't think this qualifies
as a fix.

  4acbfb6c116b ("PM: wakeup: Add out-of-band system wakeup support for devices")

Best
Markus

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 289 bytes --]

  reply	other threads:[~2026-02-18 10:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13 18:08 [PATCH] can: m_can: set out-of-band wakeup if wakeup pinctrl exists Kendall Willis
2026-02-17 21:08 ` Marc Kleine-Budde
2026-02-18 10:57   ` Markus Schneider-Pargmann [this message]
2026-02-18 10:51 ` Markus Schneider-Pargmann
2026-02-19 20:31   ` Kendall Willis
2026-02-26 16:39     ` Markus Schneider-Pargmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGI1850U6GMU.AMN60BPYQ73I@baylibre.com \
    --to=msp@baylibre.com \
    --cc=d-gole@ti.com \
    --cc=k-willis@ti.com \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mailhol@kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=sebin.francis@ti.com \
    --cc=vishalm@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox