From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 501E2377ED7 for ; Thu, 5 Mar 2026 09:36:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772703392; cv=none; b=SojMf43OGOeBwrc6U0tjZBFGlI0IcZ4LwhfNEoWuLjSDYFCTIXnIzrN/pszqFyki3fwIqDnEX8L85ZerzrpYoaQ9cY1Vp50O+NKM2TNhK5iprE0lbOcx5CqT9dGI8/2wi7UvVwU4rvRoCzFaTJ4iLH95ygF0tq3gjE6jcj7baAo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772703392; c=relaxed/simple; bh=CMgXM6u7309Wn3e+oqvoc7hX9vYREWTZOtF5JH1MCY8=; h=Mime-Version:Content-Type:Date:Message-Id:From:To:Cc:Subject: References:In-Reply-To; b=qDUs3Cv3VKqnybfDreN1Mw4z/UvG6HRU4nMIYZN22p71vq2JfwI5e4p4lt8R4CJSZD6ncITr57DtGjNNEedYhI+tvfH3AD/p6ii3hbuZiIXd41nCg2Qs1HKcOPm3bLUX2VfFN0kHuir76a/NZ/vutU/4jsEpYXoqvBlxYYC9LPM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=r8n3aZlu; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="r8n3aZlu" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-439cb5af25bso1294565f8f.1 for ; Thu, 05 Mar 2026 01:36:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1772703385; x=1773308185; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:message-id:date :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Mbidr/A9XxccdAFsJsVKLL2bBtmGRz8XUrt7LUMLgOs=; b=r8n3aZluVhBTCfb7BQuBR7rtMDtwMt/hhUveTeZDZQAO4wJxkqYdVnWInamwTvoasd njRsc4y1mlFqY6e8h+MrxsQmTwUtFPEr4bGcC2jwn78y+TT5X2hBUAy+EkXK3GfkPnMc efI7YRWZmXX4iWMH3mdtVwJdLQgh9b+NgkxQAUiokU1kYqlHFgrFqn8X6Kh54oqNRJvL W9KF9PgfXi06d+0sZ2isvDvqnFTaI47uFjf39desDXwhsR9fNqaB6S1RhpTym+6cBpi7 37SVpkS6dpjv/ggxoqRfyQPvFp9lVwc3QY78bUWB4dZgVEV/oWO3UY/ChIwfz5zMSHTu wMIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772703385; x=1773308185; h=in-reply-to:references:subject:cc:to:from:message-id:date :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Mbidr/A9XxccdAFsJsVKLL2bBtmGRz8XUrt7LUMLgOs=; b=TauzUKnaipFwp/nIs3QVx7xkp7x44fvdQJCnY0vtl/kZmuuAeTSOgS+Mxtk6kAaR1d j585DX5F88hNV73Og8bNrXW/QksS3OLHuztwZ3/MDCEQWaQlOQnwscEo2HAgroSy7M/b Kee/TE6NHll9FDHyNfyKi5QPPrfzGC2j3OMgD0fc7SUIOWE8UosqNKoYHVK+phsi5Yqu n6Gmh4mFygseI/31t5Vrc6AkHeZOF9GT6p+hZL58Sjlo64dFiUVHdv66fK10bo5l3qK/ yc7agFg3yxN9LrqxV7Auv1Zc+4KI3Z1TNmNHW1JVJBWXno5KrZQ8un9RLMNxbZK++DBe B8Rw== X-Forwarded-Encrypted: i=1; AJvYcCV4jXS6tuKSNFKYMz9O4PKm5BcMsU84aSmpwEdAQYaSo9QjqZoJPO+i8qWrYhty0Y9Ga1qRN+cw5Wk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8wdGUoZ5sO473dAG3itf3Ws/22vdGoP1gKAP5qz9GsNVFwNjg GX92/cqdnB9vJQ0El4Y2L6EQhp+NZBf/0GvGYwmg3u2sa8hL4KL6NXpoTSZNNoZ5iWE= X-Gm-Gg: ATEYQzwxwLRYpDD71xdIGPn/QwPsxxYL2FDnvt8DkpuGLlv+rl23uvu/HOIVHjpopZV OHkIFYOermFG7c57PjnLkj4p8ZIr8+9qcOgs+TzgLUZEFoE4eqbE0sizZddzUIwXTPo+VnLvXa/ EZEv1de0J7mbbjD5yTnHYnJzzOWsmOEH6SglwfMwA3kDoNHoR8lVIeh2YbE4QORvMv3R5B8xZ0k PL9pO9FkMXdt0F6KGNjCjxsJCvbVZHFI/ElbqflTlK6BzuRj+vFrHR6QUdJJ5w7rZTz+0+zFHu8 Em6jf7iuSs8py94/JyvmGqBZaw8TjULmpjlLxMAXeXpUf+JT4XC1x429OHhRbtNL7jXhHpr9luO eLG9KpKI9ZC4c+B+1OhIQfL8y68YQzxaLokDgd3wkJh/k+GAgGsHlrSQAS+fHNQ1/1LSJRE0A6f MQtXGkiA0Q5ohbgVA= X-Received: by 2002:a05:6000:144f:b0:439:b564:7a6c with SMTP id ffacd0b85a97d-439c7f6a2c9mr9158913f8f.4.1772703384539; Thu, 05 Mar 2026 01:36:24 -0800 (PST) Received: from localhost ([195.52.25.213]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439c2f7eca1sm14966458f8f.11.2026.03.05.01.36.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 01:36:22 -0800 (PST) Precedence: bulk X-Mailing-List: linux-can@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: multipart/signed; boundary=b895f1e89350da7f8491f35b99d431866030fe6df54b62358155e9918430; micalg=pgp-sha512; protocol="application/pgp-signature" Date: Thu, 05 Mar 2026 10:36:14 +0100 Message-Id: From: "Markus Schneider-Pargmann" To: "Vladimir Oltean" , Cc: "Vinod Koul" , "Neil Armstrong" , , , , , , , , , , , , , , , , , , , , , "Andrzej Hajda" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Andy Yan" , "Marc Kleine-Budde" , "Vincent Mailhol" , "Nicolas Ferre" , "Alexandre Belloni" , "Claudiu Beznea" , "Markus Schneider-Pargmann" , "Geert Uytterhoeven" , "Magnus Damm" Subject: Re: [PATCH phy-next 13/22] phy: introduce phy_get_max_link_rate() helper for consumers X-Mailer: aerc 0.21.0 References: <20260304175735.2660419-1-vladimir.oltean@nxp.com> <20260304175735.2660419-14-vladimir.oltean@nxp.com> In-Reply-To: <20260304175735.2660419-14-vladimir.oltean@nxp.com> --b895f1e89350da7f8491f35b99d431866030fe6df54b62358155e9918430 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi, On Wed Mar 4, 2026 at 6:57 PM CET, Vladimir Oltean wrote: > Consumer drivers shouldn't dereference struct phy, not even to get to > its attributes. > > We have phy_get_bus_width() as a precedent for getting the bus_width > attribute, so let's add phy_get_max_link_rate() and use it in DRM and > CAN drivers. > > Signed-off-by: Vladimir Oltean > --- > Cc: Andrzej Hajda > Cc: Neil Armstrong > Cc: Robert Foss > Cc: Laurent Pinchart > Cc: Jonas Karlman > Cc: Jernej Skrabec > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Simona Vetter > Cc: Andy Yan > Cc: Marc Kleine-Budde > Cc: Vincent Mailhol > Cc: Nicolas Ferre > Cc: Alexandre Belloni > Cc: Claudiu Beznea > Cc: Markus Schneider-Pargmann > Cc: Geert Uytterhoeven > Cc: Magnus Damm > --- > drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 4 ++-- > drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +- > drivers/net/can/at91_can.c | 2 +- > drivers/net/can/flexcan/flexcan-core.c | 2 +- > drivers/net/can/m_can/m_can_platform.c | 2 +- > drivers/net/can/rcar/rcar_canfd.c | 2 +- > drivers/phy/phy-core.c | 6 ++++++ > include/linux/phy/phy.h | 6 ++++++ > 8 files changed, 19 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/driver= s/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c > index a8b6ae58cb0a..ed7ed82ddb64 100644 > --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c > +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c > @@ -1300,7 +1300,7 @@ static u32 cdns_mhdp_get_training_interval_us(struc= t cdns_mhdp_device *mhdp, > =20 > static void cdns_mhdp_fill_host_caps(struct cdns_mhdp_device *mhdp) > { > - unsigned int link_rate; > + u32 link_rate; > =20 > /* Get source capabilities based on PHY attributes */ > =20 > @@ -1308,7 +1308,7 @@ static void cdns_mhdp_fill_host_caps(struct cdns_mh= dp_device *mhdp) > if (!mhdp->host.lanes_cnt) > mhdp->host.lanes_cnt =3D 4; > =20 > - link_rate =3D mhdp->phy->attrs.max_link_rate; > + link_rate =3D phy_get_max_link_rate(mhdp->phy); > if (!link_rate) > link_rate =3D drm_dp_bw_code_to_link_rate(DP_LINK_BW_8_1); > else > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/br= idge/synopsys/dw-dp.c > index 4ab6922dd79c..79c72ee8e263 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c > @@ -536,7 +536,7 @@ static int dw_dp_link_parse(struct dw_dp *dp, struct = drm_connector *connector) > =20 > link->revision =3D link->dpcd[DP_DPCD_REV]; > link->rate =3D min_t(u32, min(dp->plat_data.max_link_rate, > - dp->phy->attrs.max_link_rate * 100), > + phy_get_max_link_rate(dp->phy) * 100), > drm_dp_max_link_rate(link->dpcd)); > link->lanes =3D min_t(u8, phy_get_bus_width(dp->phy), > drm_dp_max_lane_count(link->dpcd)); > diff --git a/drivers/net/can/at91_can.c b/drivers/net/can/at91_can.c > index 58da323f14d7..b56db253f02d 100644 > --- a/drivers/net/can/at91_can.c > +++ b/drivers/net/can/at91_can.c > @@ -1126,7 +1126,7 @@ static int at91_can_probe(struct platform_device *p= dev) > can_rx_offload_add_timestamp(dev, &priv->offload); > =20 > if (transceiver) > - priv->can.bitrate_max =3D transceiver->attrs.max_link_rate; > + priv->can.bitrate_max =3D phy_get_max_link_rate(transceiver); > =20 > if (at91_is_sam9263(priv)) > dev->sysfs_groups[0] =3D &at91_sysfs_attr_group; > diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/fle= xcan/flexcan-core.c > index f5d22c61503f..3a4307bc1d61 100644 > --- a/drivers/net/can/flexcan/flexcan-core.c > +++ b/drivers/net/can/flexcan/flexcan-core.c > @@ -2211,7 +2211,7 @@ static int flexcan_probe(struct platform_device *pd= ev) > priv->transceiver =3D transceiver; > =20 > if (transceiver) > - priv->can.bitrate_max =3D transceiver->attrs.max_link_rate; > + priv->can.bitrate_max =3D phy_get_max_link_rate(transceiver); > =20 > if (priv->devtype_data.quirks & FLEXCAN_QUIRK_NR_IRQ_3) { > priv->irq_boff =3D platform_get_irq(pdev, 1); > diff --git a/drivers/net/can/m_can/m_can_platform.c b/drivers/net/can/m_c= an/m_can_platform.c > index 56da411878af..73525be6566b 100644 > --- a/drivers/net/can/m_can/m_can_platform.c > +++ b/drivers/net/can/m_can/m_can_platform.c > @@ -132,7 +132,7 @@ static int m_can_plat_probe(struct platform_device *p= dev) > } > =20 > if (transceiver) > - mcan_class->can.bitrate_max =3D transceiver->attrs.max_link_rate; > + mcan_class->can.bitrate_max =3D phy_get_max_link_rate(transceiver); > =20 > priv->base =3D addr; > priv->mram_base =3D mram_addr; > diff --git a/drivers/net/can/rcar/rcar_canfd.c b/drivers/net/can/rcar/rca= r_canfd.c > index eaf8cac78038..645d5671705d 100644 > --- a/drivers/net/can/rcar/rcar_canfd.c > +++ b/drivers/net/can/rcar/rcar_canfd.c > @@ -1885,7 +1885,7 @@ static int rcar_canfd_channel_probe(struct rcar_can= fd_global *gpriv, u32 ch, > priv->channel =3D ch; > priv->gpriv =3D gpriv; > if (transceiver) > - priv->can.bitrate_max =3D transceiver->attrs.max_link_rate; > + priv->can.bitrate_max =3D phy_get_max_link_rate(transceiver); > priv->can.clock.freq =3D fcan_freq; > dev_info(dev, "can_clk rate is %u\n", priv->can.clock.freq); > =20 > diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c > index a1aff00fba7c..89f7410241aa 100644 > --- a/drivers/phy/phy-core.c > +++ b/drivers/phy/phy-core.c > @@ -640,6 +640,12 @@ void phy_set_bus_width(struct phy *phy, int bus_widt= h) > } > EXPORT_SYMBOL_GPL(phy_set_bus_width); > =20 > +u32 phy_get_max_link_rate(struct phy *phy) > +{ All of the can drivers that would use this function are checking phy before assigning the max_link_rate: if (transceiver) priv->can.bitrate_max =3D transceiver->attrs.max_link_rate; Would it be reasonable to have if (!phy) return 0; in this function to be able to drop these individual checks of the drivers? This would be similar to clk_get_rate() which does the same check and return 0 for convenience. Best Markus > + return phy->attrs.max_link_rate; > +} > +EXPORT_SYMBOL_GPL(phy_get_max_link_rate); > + > /** > * _of_phy_get() - lookup and obtain a reference to a phy by phandle > * @np: device_node for which to get the phy > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > index 36307e47760d..af9c3e795786 100644 > --- a/include/linux/phy/phy.h > +++ b/include/linux/phy/phy.h > @@ -57,6 +57,7 @@ int phy_notify_disconnect(struct phy *phy, int port); > int phy_notify_state(struct phy *phy, union phy_notify state); > int phy_get_bus_width(struct phy *phy); > void phy_set_bus_width(struct phy *phy, int bus_width); > +u32 phy_get_max_link_rate(struct phy *phy); > #else > static inline struct phy *phy_get(struct device *dev, const char *string= ) > { > @@ -256,6 +257,11 @@ static inline int phy_get_bus_width(struct phy *phy) > static inline void phy_set_bus_width(struct phy *phy, int bus_width) > { > } > + > +static inline u32 phy_get_max_link_rate(struct phy *phy) > +{ > + return 0; > +} > #endif /* IS_ENABLED(CONFIG_GENERIC_PHY) */ > =20 > #endif /* __PHY_CONSUMER_H */ --b895f1e89350da7f8491f35b99d431866030fe6df54b62358155e9918430 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iKMEABYKAEsWIQSJYVVm/x+5xmOiprOFwVZpkBVKUwUCaalOjxsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMSwyLDIRHG1zcEBiYXlsaWJyZS5jb20ACgkQhcFWaZAVSlPc SwEAt3Fg0ly9qnS+HJQv96JGhcc9ssPHPspnN0LcoiUH76oBAJJ1UWuuXcnIsBb3 namewJQN1U0nDnFUFRtJbSq49LcK =6g8b -----END PGP SIGNATURE----- --b895f1e89350da7f8491f35b99d431866030fe6df54b62358155e9918430--