From: "Markus Schneider-Pargmann" <msp@baylibre.com>
To: "Marc Kleine-Budde" <mkl@pengutronix.de>, <sashiko-bot@kernel.org>
Cc: "Oleksij Rempel" <o.rempel@pengutronix.de>,
"Vincent Mailhol" <mailhol@kernel.org>,
<linux-can@vger.kernel.org>,
"Oliver Hartkopp" <socketcan@hartkopp.net>
Subject: Re: [PATCH net 12/22] can: m_can: m_can_class_suspend(): fix suspend deinit() error path
Date: Thu, 01 Oct 2026 14:44:07 +0200 [thread overview]
Message-ID: <DLTIEP75FV1D.1V01M5U0KJVL8@baylibre.com> (raw)
In-Reply-To: <20260929-utopian-adventurous-jaybird-e6678f-mkl@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]
On Tue Sep 29, 2026 at 10:34 PM CEST, Marc Kleine-Budde wrote:
> On 29.09.2026 19:33:36, sashiko-bot@kernel.org wrote:
>> Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
>> - [High] can: m_can: data race on active_interrupts between suspend error path and ISR
This is a good point. I think I will leave the active_interrupts as they
are and instead re-enable the hrtimer. That was one of the two solutions
I was thinking about. This should also fix the last point sashiko made.
>> - [Medium] can: tcan4x5x: unbalanced enable_irq_wake() when m_can_class_suspend() fails
True, should be a follow-up fix. This is already what happens now
without the patch. The patch doesn't change this behavior but also
doesn't fix it.
>> - [Medium] can: m_can: polling hrtimer is permanently disabled on suspend failure
>> --
>>
>> commit c427425150087d727cfdd3220f1be90e0a87c37e
>> Author: Markus Schneider-Pargmann (TI) <msp@baylibre.com>
>
> Markus can you comment on these? I'll drop this patch for the net PR for
> now.
Thanks I didn't get these.
Also I am wondering why sashiko didn't flag any of this on my patch
submission...
https://sashiko.dev/#/patchset/20260918-v7-3-topic-mcan-suspend-fix-fix-v1-1-e24fa70c754e%40baylibre.com
Best
Markus
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 289 bytes --]
next prev parent reply other threads:[~2026-10-01 12:44 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 18:45 [PATCH net 0/22] pull-request: can 2026-09-28 Marc Kleine-Budde
2026-09-28 18:45 ` [PATCH net 01/22] can: dev: can_dropped_invalid_skb: drop CAN XL frames on non-CAN XL devices Marc Kleine-Budde
2026-09-28 19:36 ` netdev-bot+sinfo
2026-09-28 18:45 ` [PATCH net 02/22] can: skb: make echo skb freeing safe in any IRQ context Marc Kleine-Budde
2026-09-28 18:45 ` [PATCH net 03/22] can: skb: make CAN skb allocation failure paths IRQ-safe Marc Kleine-Budde
2026-09-28 18:45 ` [PATCH net 04/22] can: dev: can_put_echo_skb(): free skb on invalid echo index Marc Kleine-Budde
2026-09-28 18:45 ` [PATCH net 05/22] can: dev: init_can_skb(): restore skb header initialization Marc Kleine-Budde
2026-09-28 18:45 ` [PATCH net 06/22] can: j1939: j1939_sk_bind(): fix j1939_ecu leak when re-bind failed Marc Kleine-Budde
2026-09-29 8:56 ` Marc Kleine-Budde
2026-09-29 9:07 ` Tetsuo Handa
2026-09-29 9:39 ` Marc Kleine-Budde
2026-09-29 9:48 ` Tetsuo Handa
2026-09-29 9:53 ` Marc Kleine-Budde
2026-09-29 9:46 ` Marc Kleine-Budde
2026-10-04 11:44 ` Tetsuo Handa
2026-09-28 18:45 ` [PATCH net 07/22] can: isotp: check the frame type, not just the length Marc Kleine-Budde
2026-09-28 18:45 ` [PATCH net 08/22] can: cc770: platform_get_irq(): propagate the error Marc Kleine-Budde
2026-09-29 19:33 ` sashiko-bot
2026-09-28 18:45 ` [PATCH net 09/22] can: cc770: fix the clock divider check on the platform bus Marc Kleine-Budde
2026-09-28 18:45 ` [PATCH net 10/22] can: kvaser_pciefd: fix use-after-free in bec poll timer Marc Kleine-Budde
2026-09-28 18:45 ` [PATCH net 11/22] can: m_can: pci: add missing pm_runtime_dont_use_autosuspend() call Marc Kleine-Budde
2026-09-28 18:45 ` [PATCH net 12/22] can: m_can: m_can_class_suspend(): fix suspend deinit() error path Marc Kleine-Budde
2026-09-29 19:33 ` sashiko-bot
2026-09-29 20:34 ` Marc Kleine-Budde
2026-10-01 12:44 ` Markus Schneider-Pargmann [this message]
2026-10-01 12:57 ` Oliver Hartkopp
2026-09-28 18:45 ` [PATCH net 13/22] can: sun4i_can: sun4ican_probe(): fix clk leak Marc Kleine-Budde
2026-09-28 18:45 ` [PATCH net 14/22] can: xilinx_can: set CAN FD flags on received frames Marc Kleine-Budde
2026-09-28 18:45 ` [PATCH net 15/22] can: mcp251xfd: mcp251xfd_probe(): reject devices without match data Marc Kleine-Budde
2026-09-28 18:45 ` [PATCH net 16/22] can: hi311x: drop hi3110_lock before free_irq() on open failure Marc Kleine-Budde
2026-09-28 18:45 ` [PATCH net 17/22] can: ems_usb: use usb_kill_urb() to stop the intr URB Marc Kleine-Budde
2026-09-28 18:45 ` [PATCH net 18/22] usb: f81604: fix struct f81604_int_data size mismatch Marc Kleine-Budde
2026-09-28 18:45 ` [PATCH net 19/22] can: gs_usb: kill RX URBs before destroying the netdevs Marc Kleine-Budde
2026-09-28 18:45 ` [PATCH net 20/22] can: gs_usb: add workarounds for HScanT USB to CAN adapter Marc Kleine-Budde
2026-09-28 18:45 ` [PATCH net 21/22] can: kvaser_usb: validate command format before parsing in hydra receive path Marc Kleine-Budde
2026-09-28 18:45 ` [PATCH net 22/22] can: peak_usb: fix missing CAN_ERR_FLAG when reporting error counters Marc Kleine-Budde
2026-09-29 1:09 ` [PATCH net 0/22] pull-request: can 2026-09-28 Jakub Kicinski
2026-09-29 21:12 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DLTIEP75FV1D.1V01M5U0KJVL8@baylibre.com \
--to=msp@baylibre.com \
--cc=linux-can@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=o.rempel@pengutronix.de \
--cc=sashiko-bot@kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox