Linux CAN drivers development
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org, Peter Fink <pfink@christ-es.de>,
	stable@vger.kernel.org, Ryan Edwards <ryan.edwards@gmail.com>
Subject: Re: [PATCH] can: gs_usb: fix size parameter to usb_free_coherent() calls
Date: Sat, 26 Nov 2022 08:04:11 +0100	[thread overview]
Message-ID: <Y4G6a4hlJFgH+iAy@kroah.com> (raw)
In-Reply-To: <20221125203217.cuv63t4ijxwmqun7@pengutronix.de>

On Fri, Nov 25, 2022 at 09:32:17PM +0100, Marc Kleine-Budde wrote:
> Hello Greg,
> 
> with v5.18-rc1 in commit
> 
> | c359931d2545 ("can: gs_usb: use union and FLEX_ARRAY for data in struct gs_host_frame")
> 
> a bug in the gs_usb driver in the usage of usb_free_coherent() was
> introduced. With v6.1-rc1
> 
> | 62f102c0d156 ("can: gs_usb: remove dma allocations")
> 
> the DMA allocation was removed altogether from the driver, fixing the
> bug unintentionally.
> 
> We can either cherry-pick 62f102c0d156 ("can: gs_usb: remove dma
> allocations") on v6.0, v5.19, and v5.18 or apply this patch, which fixes
> the usage of usb_free_coherent() only.

We should always take what is in Linus's tree, that's the best solution.
Does the change backport cleanly?

And 5.19 and 5.18 are long end-of-life, no need to worry about them.
Only 6.0 matters right now.

thanks,

greg k-h

  reply	other threads:[~2022-11-26 10:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-25 20:17 [PATCH] can: gs_usb: fix size parameter to usb_free_coherent() calls Marc Kleine-Budde
2022-11-25 20:32 ` Marc Kleine-Budde
2022-11-26  7:04   ` Greg Kroah-Hartman [this message]
2022-11-26 19:26     ` Marc Kleine-Budde
2022-11-29 16:54       ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4G6a4hlJFgH+iAy@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=pfink@christ-es.de \
    --cc=ryan.edwards@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox