public inbox for linux-can@vger.kernel.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
	Charles Han <hanchunchao@inspur.com>
Cc: linux-can@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
	linux-doc@vger.kernel.org, mkl@pengutronix.de,
	manivannan.sadhasivam@linaro.org, thomas.kopp@microchip.com,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	cem@kernel.org, djwong@kernel.org, corbet@lwn.net
Subject: Re: [PATCH] Documentation: Remove repeated word in docs
Date: Fri, 7 Feb 2025 08:25:35 +0700	[thread overview]
Message-ID: <Z6VhD9_0qt4yRV6N@archie.me> (raw)
In-Reply-To: <e0aeefc5-bf01-42ab-91e4-e727d560c983@wanadoo.fr>

[-- Attachment #1: Type: text/plain, Size: 1849 bytes --]

On Thu, Feb 06, 2025 at 07:56:36PM +0900, Vincent Mailhol wrote:
> On 06/02/2025 at 18:15, Charles Han wrote:
> > diff --git a/Documentation/filesystems/xfs/xfs-online-fsck-design.rst b/Documentation/filesystems/xfs/xfs-online-fsck-design.rst
> > index 12aa63840830..994f9e5638ee 100644
> > --- a/Documentation/filesystems/xfs/xfs-online-fsck-design.rst
> > +++ b/Documentation/filesystems/xfs/xfs-online-fsck-design.rst
> > @@ -4521,7 +4521,7 @@ Both online and offline repair can use this strategy.
> >  | For this second effort, the ondisk parent pointer format as originally   |
> >  | proposed was ``(parent_inum, parent_gen, dirent_pos) → (dirent_name)``.  |
> >  | The format was changed during development to eliminate the requirement   |
> > -| of repair tools needing to to ensure that the ``dirent_pos`` field       |
> > +| of repair tools needing to ensure that the ``dirent_pos`` field       |
> 
> This breaks the indentation of the pipe on the right.

Indeed because Sphinx spills out malformed table error:

Documentation/filesystems/xfs/xfs-online-fsck-design.rst:4479: ERROR: Malformed table.
> <snipped>...
| For this second effort, the ondisk parent pointer format as originally   |
| proposed was ``(parent_inum, parent_gen, dirent_pos) → (dirent_name)``.  |
| The format was changed during development to eliminate the requirement   |
| of repair tools needing to ensure that the ``dirent_pos`` field       |
| always matched when reconstructing a directory.                          |
|                                                                          |
| There were a few other ways to have solved that problem:                 |
> <snipped>... 

Hence I didn't see that historical sidebar in htmldocs output.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2025-02-07  1:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-06  9:15 [PATCH] Documentation: Remove repeated word in docs Charles Han
2025-02-06  9:30 ` Marc Kleine-Budde
2025-02-06 10:56 ` Vincent Mailhol
2025-02-07  1:25   ` Bagas Sanjaya [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z6VhD9_0qt4yRV6N@archie.me \
    --to=bagasdotme@gmail.com \
    --cc=cem@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=djwong@kernel.org \
    --cc=hanchunchao@inspur.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mailhol.vincent@wanadoo.fr \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=mkl@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=thomas.kopp@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox