From: Francesco Dolcini <francesco@dolcini.it>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Francesco Dolcini <francesco@dolcini.it>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
linux-can@vger.kernel.org,
Thomas Kopp <thomas.kopp@microchip.com>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Subject: Re: Oops on mcp251xfd open on 6.6.52
Date: Tue, 24 Sep 2024 00:41:04 +0200 [thread overview]
Message-ID: <ZvHugNKM-Ilu4K3K@gaggiata.pivistrello.it> (raw)
In-Reply-To: <20240923-quixotic-okapi-of-rain-99ae09-mkl@pengutronix.de>
Hello Marc,
On Mon, Sep 23, 2024 at 04:36:16PM +0200, Marc Kleine-Budde wrote:
> On 23.09.2024 14:00:27, Francesco Dolcini wrote:
> > On Mon, Sep 23, 2024 at 01:57:07PM +0200, Marc Kleine-Budde wrote:
> > > On 23.09.2024 13:53:10, Francesco Dolcini wrote:
> > > > I got the following Oops on doing a simple ip link set canX up, running
> > > > on an i.MX8MM SoC.
> > > >
> > > > This was reproduced with some automated testing, I have not tried to
> > > > reproduce it so far. Any idea or hint? It seems systematic, introduced
> > > > around 12th september on the v6.6.y branch.
> > >
> > > Which Kernel version are you using?
> >
> > v6.6.52 is reproducing the issue, I guess it started on some previous
> > v6.6.x kernel (with x < 52), but I was not able to dig out the logs
> > running on older kernel from our automated testing (yet).
> >
> > I was not able to test mainline (yet).
>
> Can you cherry-pick these and see if it fixes your problem?
>
> 51b2a7216122 ("can: mcp251xfd: properly indent labels")
> a7801540f325 ("can: mcp251xfd: move mcp251xfd_timestamp_start()/stop() into mcp251xfd_chip_start/stop()")
Yes, these 2 commits fix the issue.
In addition I noticed that also 6.1.111 is affected by the exact same Oops.
Thanks!
BTW, to reproduce, just
ip link set can0 type can bitrate 1000000
ip link set can0 up
How to we move forward now? Would you ask greg to backport to stable kernel also
these 2 patches (I assume that something was backported that broke the
functionality at some point)?
Francesco
next prev parent reply other threads:[~2024-09-23 22:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 11:53 Oops on mcp251xfd open on 6.6.52 Francesco Dolcini
2024-09-23 11:57 ` Marc Kleine-Budde
2024-09-23 12:00 ` Francesco Dolcini
2024-09-23 14:36 ` Marc Kleine-Budde
2024-09-23 22:41 ` Francesco Dolcini [this message]
2024-09-24 6:21 ` Marc Kleine-Budde
2024-09-24 6:53 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvHugNKM-Ilu4K3K@gaggiata.pivistrello.it \
--to=francesco@dolcini.it \
--cc=linux-can@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mkl@pengutronix.de \
--cc=thomas.kopp@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox