public inbox for linux-can@vger.kernel.org
 help / color / mirror / Atom feed
From: Jimmy Assarsson <jimmyassarsson@gmail.com>
To: Jimmy Assarsson <extja@kvaser.com>,
	linux-can@vger.kernel.org,
	Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
	Marc Kleine-Budde <mkl@pengutronix.de>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 05/10] can: kvaser_pciefd: Store device channel index
Date: Thu, 24 Jul 2025 09:08:52 +0200	[thread overview]
Message-ID: <a88f2cfa-69e1-400e-ad67-01ae83f3f9f6@gmail.com> (raw)
In-Reply-To: <20250724063651.8-6-extja@kvaser.com>


On 7/24/25 8:36 AM, Jimmy Assarsson wrote:
> Store device channel index in netdev.dev_port.
> 
> Fixes: 26ad340e582d ("can: kvaser_pciefd: Add driver for Kvaser PCIEcan devices")
> Signed-off-by: Jimmy Assarsson <extja@kvaser.com>
> ---
> Changes in v2:
>    - Add Fixes tag.
> 
>   drivers/net/can/kvaser_pciefd.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/can/kvaser_pciefd.c b/drivers/net/can/kvaser_pciefd.c
> index 7153b9ea0d3d..8dcb1d1c67e4 100644
> --- a/drivers/net/can/kvaser_pciefd.c
> +++ b/drivers/net/can/kvaser_pciefd.c
> @@ -1028,6 +1028,7 @@ static int kvaser_pciefd_setup_can_ctrls(struct kvaser_pciefd *pcie)
>   		can->completed_tx_bytes = 0;
>   		can->bec.txerr = 0;
>   		can->bec.rxerr = 0;
> +		can->can.dev->dev_port = i;
>   
>   		init_completion(&can->start_comp);
>   		init_completion(&can->flush_comp);

Would it be better to submit this as a separate patch, or keep it within
this patch series?

Best regards,
jimmy


  reply	other threads:[~2025-07-24  7:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-24  6:36 [PATCH v2 00/10] can: kvaser_pciefd: Simplify identification of physical CAN interfaces Jimmy Assarsson
2025-07-24  6:36 ` [PATCH v2 01/10] can: kvaser_pciefd: Add support to control CAN LEDs on device Jimmy Assarsson
2025-07-24  6:36 ` [PATCH v2 02/10] can: kvaser_pciefd: Add support for ethtool set_phys_id() Jimmy Assarsson
2025-07-24  6:36 ` [PATCH v2 03/10] can: kvaser_pciefd: Add intermediate variable for device struct in probe() Jimmy Assarsson
2025-07-24  6:36 ` [PATCH v2 04/10] can: kvaser_pciefd: Store the different firmware version components in a struct Jimmy Assarsson
2025-07-24  6:36 ` [PATCH v2 05/10] can: kvaser_pciefd: Store device channel index Jimmy Assarsson
2025-07-24  7:08   ` Jimmy Assarsson [this message]
2025-07-24  7:54     ` Vincent Mailhol
2025-07-24  6:36 ` [PATCH v2 06/10] can: kvaser_pciefd: Split driver into C-file and header-file Jimmy Assarsson
2025-07-24  6:36 ` [PATCH v2 07/10] can: kvaser_pciefd: Add devlink support Jimmy Assarsson
2025-07-24  6:36 ` [PATCH v2 08/10] can: kvaser_pciefd: Expose device firmware version via devlink info_get() Jimmy Assarsson
2025-07-24  6:36 ` [PATCH v2 09/10] can: kvaser_pciefd: Add devlink port support Jimmy Assarsson
2025-07-24  6:36 ` [PATCH v2 10/10] Documentation: devlink: add devlink documentation for the kvaser_pciefd driver Jimmy Assarsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a88f2cfa-69e1-400e-ad67-01ae83f3f9f6@gmail.com \
    --to=jimmyassarsson@gmail.com \
    --cc=extja@kvaser.com \
    --cc=linux-can@vger.kernel.org \
    --cc=mailhol.vincent@wanadoo.fr \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox