From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH] can: j1939: undo increment when j1939_local_ecu_get() fails
Date: Mon, 8 Sep 2025 06:57:14 +0200 [thread overview]
Message-ID: <aL5iKvYG6CijWsEF@pengutronix.de> (raw)
In-Reply-To: <40478f86-3de1-44c1-ba6f-6de3ed40bdeb@I-love.SAKURA.ne.jp>
On Sun, Sep 07, 2025 at 04:42:33PM +0900, Tetsuo Handa wrote:
> On 2025/09/05 17:31, Oleksij Rempel wrote:
> > On Sun, Aug 24, 2025 at 07:27:40PM +0900, Tetsuo Handa wrote:
> >> Since j1939_sk_bind() and j1939_sk_release() call j1939_local_ecu_put()
> >> when J1939_SOCK_BOUND was already set, but the error handling path for
> >> j1939_sk_bind() will not set J1939_SOCK_BOUND when j1939_local_ecu_get()
> >> fails, j1939_local_ecu_get() needs to undo priv->ents[sa].nusers++ when
> >> j1939_local_ecu_get() returns an error.
> >>
> >> Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")
> >> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> >
> > Tested-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
> >
> > Thank you!
>
> Thank you for responding.
> Do I need to take some action (e.g. sending to netdev@vger.kernel.org )
> on these three patches?
Nothing is needed for now. As soon as CAN maintainers will have time to
take look at it, the patches will be taken or changes may be requested.
Best Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2025-09-08 4:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-24 10:27 [PATCH] can: j1939: undo increment when j1939_local_ecu_get() fails Tetsuo Handa
2025-09-05 8:31 ` Oleksij Rempel
2025-09-07 7:42 ` Tetsuo Handa
2025-09-08 4:57 ` Oleksij Rempel [this message]
2025-09-09 11:54 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aL5iKvYG6CijWsEF@pengutronix.de \
--to=o.rempel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox