[PATCH 0/4] can: flexcan: fix state transition, suppress irq flooding

[PATCH 0/4] can: flexcan: fix state transition, suppress irq flooding

[ZHU Yi (ST-FIR/ENG1-Zhu)]

From 9253741b7d8bdd4fabe41a8dc2211869589f0f18 Mon Sep 17 00:00:00 2001
From: Zhu Yi <yi.zhu5@cn.bosch.com>
Date: Tue, 5 Sep 2017 16:09:04 +0800
Subject: [PATCH 0/4] can: flexcan: fix state transition, suppress irq flooding

A state transition regression was found after the rx-offload patches
were introduced. Additionally, when FLEXCAN_QUIRK_BROKEN_ERR_STATE is
enabled, error interrupt flooding may happen. This can cause a
performance hit on low end systems in combination with high bitrates.

Patch 1 fixes the state change regression by calling flexcan_irq_state()
upon any interrupt.

Patch 2 renames the legacy FLEXCAN_QUIRK_BROKEN_ERR_STATE to
FLEXCAN_QUIRK_BROKEN_WERR_STATE. This is the first step to tackle the
error interrupt flooding issue.

Patch 3 introduces FLEXCAN_QUIRK_BROKEN_PERR_STATE and uses the two
[PW]ERR_STATE quirks to limit error interrupt occurrences to the minimum
required to report correct state transitions.

Patch 4 enables FLEXCAN_QUIRK_BROKEN_PERR_STATE on i.MX6 to enable
correct state transitions on this SOC.

All patches were tested on i.MX6 with kernel v4.11. They were also
tested with disabled [TR]WRN_INT and enabled
FLEXCAN_QUIRK_BROKEN_PERR_STATE and FLEXCAN_QUIRK_BROKEN_WERR_STATE on
i.MX6 to verify that it should work with:
1. new FlexCAN core (with    [TR]WRN_INT connected), and
2. old FlexCAN core (without [TR]WRN_INT connected)

Because we cannot perform test on FlexCAN cores except i.MX6, the fix is
not enabled for other SOCs, e.g. i.MX53. These SOCs could also benefit
after to enabling the appropriate [PW]ERR_STATE quirk.

This series applies to kernel v4.13-rc5, but should also work on any
kernel which already switched to the rx-offload version of the flexcan
driver.

Zhu Yi (4):
  can: flexcan: fix state transition regression
  can: flexcan: rename legacy error state quirk
  can: flexcan: implement error passive state quirk
  can: flexcan: fix i.MX6 state transition issue

 drivers/net/can/flexcan.c | 90 +++++++++++++++++++++++++++++++++++++++--------
 1 file changed, 76 insertions(+), 14 deletions(-)

-- 
2.7.4

RE: [PATCH 0/4] can: flexcan: fix state transition, suppress irq flooding

[Jonas Mark (ST-FIR/ENG1)]

Hello Wolfgang and Marc,

> From 9253741b7d8bdd4fabe41a8dc2211869589f0f18 Mon Sep 17 00:00:00 2001
> From: Zhu Yi <yi.zhu5@cn.bosch.com>
> Date: Tue, 5 Sep 2017 16:09:04 +0800
> Subject: [PATCH 0/4] can: flexcan: fix state transition, suppress irq flooding

Is the patch set already on its way upstream or is there something we still need to do?

Regards,
Mark

Re: [PATCH 0/4] can: flexcan: fix state transition, suppress irq flooding

[Marc Kleine-Budde]

[-- Attachment #1.1: Type: text/plain, Size: 745 bytes --]

On 10/02/2017 11:05 AM, Jonas Mark (ST-FIR/ENG1) wrote:
> Hello Wolfgang and Marc,
> 
>> From 9253741b7d8bdd4fabe41a8dc2211869589f0f18 Mon Sep 17 00:00:00 2001
>> From: Zhu Yi <yi.zhu5@cn.bosch.com>
>> Date: Tue, 5 Sep 2017 16:09:04 +0800
>> Subject: [PATCH 0/4] can: flexcan: fix state transition, suppress irq flooding
> 
> Is the patch set already on its way upstream or is there something we still need to do?

I'll push the series to upstream.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

AW: [PATCH 0/4] can: flexcan: fix state transition, suppress irq flooding

[Jonas Mark (ST-FIR/ENG1)]

Hello Marc,

I have to apologize but I did not pick the latest version of the patch set for poking Wolfgang you.

I scanned through the mailing list archive and the latest state of the patches is this one:

From 1841984a19b58504fcf1c73825326d2c1b034019 Mon Sep 17 00:00:00 2001
From: Zhu Yi <yi.zhu5@cn.bosch.com>
Date: Thu, 14 Sep 2017 10:33:48 +0800
Subject: [PATCH V1 0/6] can: flexcan: fix state transition, suppress irq flooding

It also contains Wolfgang's Acked-by.

So this one is definitely not the latest:

> >> From 9253741b7d8bdd4fabe41a8dc2211869589f0f18 Mon Sep 17 00:00:00
> 2001
> >> From: Zhu Yi <yi.zhu5@cn.bosch.com>
> >> Date: Tue, 5 Sep 2017 16:09:04 +0800
> >> Subject: [PATCH 0/4] can: flexcan: fix state transition, suppress irq flooding
> >
> > Is the patch set already on its way upstream or is there something we still need
> to do?
> 
> I'll push the series to upstream.

Regards,
Mark