Re: [PATCH 3/3] can: enable memcg accounting for user triggered allocations

[Oleksij Rempel <o.rempel@pengutronix.de>]

On Sat, Nov 07, 2026 at 02:35:20PM +0100, Oliver Hartkopp wrote:
> 
> 
> On 07.11.26 14:14, sashiko-bot@kernel.org wrote:
> > Thank you for your contribution! Sashiko AI review found no new issues
> > in this patch, but noticed 1 related pre-existing issue it does not
> > introduce:
> > - [Medium] can: j1939: non-zero setsockopt return value in
> >    j1939_sk_setsockopt_flag() [1]
> > --
> > 
> > commit b3ee6688711331e68a7e275f9b72d5b3fa8b7ee5
> > Author: Oliver Hartkopp <socketcan@hartkopp.net>
> > 
> > can: enable memcg accounting for user triggered allocations
> > 
> > This commit enables memcg accounting via GFP_KERNEL_ACCOUNT and
> > SLAB_ACCOUNT for user-triggered allocations in the CAN core, BCM, ISOTP,
> > J1939, and RAW socket protocols.
> > 
> > Link: https://lore.kernel.org/linux-can/350df96b-5f69-490e-b39e-ed6e9bca4754@hartkopp.net/
> > 
> > > diff --git a/net/can/j1939/socket.c b/net/can/j1939/socket.c
> > > index 50a598ef5fd4a..c832465876049 100644
> > > --- a/net/can/j1939/socket.c
> > > +++ b/net/can/j1939/socket.c
> > > @@ -716,9 +716,14 @@ static int j1939_sk_setsockopt(struct socket *sock, int level, int optname,
> > >   				return -EINVAL;
> > >   			count = optlen / sizeof(*filters);
> > > -			filters = memdup_sockptr(optval, optlen);
> > > -			if (IS_ERR(filters))
> > > -				return PTR_ERR(filters);
> > > +			filters = kmalloc(optlen, GFP_KERNEL_ACCOUNT);
> > > +			if (!filters)
> > > +				return -ENOMEM;
> > > +
> > > +			if (copy_from_sockptr(filters, optval, optlen)) {
> > > +				kfree(filters);
> > > +				return -EFAULT;
> > > +			}
> > >   			for (f = filters, c = count; c; f++, c--) {
> > >   				f->name &= f->name_mask;
> > 
> > [Severity: Medium]
> > This problem wasn't introduced by this patch, but should
> > j1939_sk_setsockopt_flag() return 0 instead of tmp [1]?
> 
> This might be a can-next topic and has nothing to do with this patch.
> 
> @Oleksij: Would you like to take this suggestion?

Ack, on my todo.

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |