From: Judith Mendez <jm@ti.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
<linux-can@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Schuyler Patton <spatton@ti.com>,
Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>,
Oliver Hartkopp <socketcan@hartkopp.net>,
Simon Horman <simon.horman@corigine.com>
Subject: Re: [PATCH v4 2/4] can: m_can: Add hrtimer to generate software interrupt
Date: Tue, 2 May 2023 13:09:01 -0500 [thread overview]
Message-ID: <b31f3a6a-e6ab-71a3-fb78-d01f2fe00464@ti.com> (raw)
In-Reply-To: <20230502-twiddling-threaten-d032287d4630-mkl@pengutronix.de>
Hello Marc
On 5/2/23 01:37, Marc Kleine-Budde wrote:
> On 01.05.2023 17:46:22, Judith Mendez wrote:
>> Add an hrtimer to MCAN class device. Each MCAN will have its own
>> hrtimer instantiated if there is no hardware interrupt found and
>> poll-interval property is defined in device tree M_CAN node.
>>
>> The hrtimer will generate a software interrupt every 1 ms. In
>> hrtimer callback, we check if there is a transaction pending by
>> reading a register, then process by calling the isr if there is.
>>
>> Signed-off-by: Judith Mendez <jm@ti.com>
>
> I think this patch is as good as it gets, given the HW and SW
> limitations of the coprocessor.
>
> Some minor nitpicks inline. No need to resend from my point of view,
> I'll fixup while applying the patch.
Thanks Marc, really appreciate your feedback and attention.
Same to everyone who helped make these patches better. (:
regards,
Judith
next prev parent reply other threads:[~2023-05-02 18:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 22:46 [PATCH v4 0/4] Enable multiple MCAN on AM62x Judith Mendez
2023-05-01 22:46 ` [PATCH v4 1/4] dt-bindings: net: can: Add poll-interval for MCAN Judith Mendez
2023-05-05 21:29 ` Rob Herring
2023-05-09 12:27 ` Marc Kleine-Budde
2023-05-09 17:02 ` Judith Mendez
2023-05-01 22:46 ` [PATCH v4 2/4] can: m_can: Add hrtimer to generate software interrupt Judith Mendez
2023-05-02 6:37 ` Marc Kleine-Budde
2023-05-02 18:09 ` Judith Mendez [this message]
2023-05-09 22:18 ` Judith Mendez
2023-05-10 7:21 ` Marc Kleine-Budde
2023-05-10 14:23 ` Judith Mendez
2023-05-01 22:46 ` [PATCH v4 3/4] DO_NOT_MERGE arm64: dts: ti: Add AM62x MCAN MAIN domain transceiver overlay Judith Mendez
2023-05-02 0:18 ` Nishanth Menon
2023-05-01 22:46 ` [PATCH v4 4/4] DO_NOT_MERGE arm64: dts: ti: Enable MCU MCANs for AM62x Judith Mendez
2023-05-02 6:52 ` [PATCH v4 0/4] Enable multiple MCAN on AM62x Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b31f3a6a-e6ab-71a3-fb78-d01f2fe00464@ti.com \
--to=jm@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=pabeni@redhat.com \
--cc=rcsekar@samsung.com \
--cc=robh+dt@kernel.org \
--cc=simon.horman@corigine.com \
--cc=socketcan@hartkopp.net \
--cc=spatton@ti.com \
--cc=vigneshr@ti.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox