From: Vincent Mailhol <mailhol@kernel.org>
To: Oliver Hartkopp <socketcan@hartkopp.net>,
Vincent Mailhol <mailhol@kernel.org>,
linux-can@vger.kernel.org
Subject: Re: [RFC PATCH v5 2/2] can: reject CAN FD content when disabled on CAN XL interfaces
Date: Thu, 11 Sep 2025 01:19:42 +0900 [thread overview]
Message-ID: <b6637b79-6377-4038-967f-0354a32eb2c3@kernel.org> (raw)
In-Reply-To: <3a963548-faa9-4611-a3cf-e41b425968a8@hartkopp.net>
On 10/09/2025 at 17:48, Oliver Hartkopp wrote:
> On 10.09.25 09:40, Vincent Mailhol wrote:
>> On 10/09/2025 at 16:27, Oliver Hartkopp wrote:
>
>>>> /* CAN XL is allowed on virtual interfaces if it fits the MTU */
>>>> if (!priv)
>>>> return dev->mtu == CANXL_MTU;
>>>
>>> return can_is_canxl_dev_mtu(mtu);
>>>
>>> The MTU of CAN XL interfaces might vary.
>>
>> Maybe this is something that we discussed before, I do not remember, but how is
>> it that the MTU can vary?
>>
>> MTU is the *Maximum* Transmission Unit. I understand that the size of a CAN XL
>> frame is variable, but the MTU should be constant, right? Why can it vary?
>
> Depending on the realtime requirements the length of the CAN frames (and
> therefore the time the bus is blocked) the MTU can be reduced. This is (like the
> bitrate settings) a network architects decision which is enforced by setting the
> MTU accordingly.
Is this an extension we offer in Socket CAN? The standard says nothing about
having the MTU configurable.
For CAN FD, we forcefully set the MTU in netlink.c
https://elixir.bootlin.com/linux/v6.16/source/drivers/net/can/dev/netlink.c#L228
I will have to think of what are the implication for CAN XL.
Yours sincerely,
Vincent Mailhol
next prev parent reply other threads:[~2025-09-10 16:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 9:24 [RFC PATCH v5 1/2] can: skb: enforce CANFD_FDF check in can_is_canfd_skb() Oliver Hartkopp
2025-09-09 9:24 ` [RFC PATCH v5 2/2] can: reject CAN FD content when disabled on CAN XL interfaces Oliver Hartkopp
2025-09-09 16:36 ` Oliver Hartkopp
2025-09-10 5:13 ` Vincent Mailhol
2025-09-10 7:27 ` Oliver Hartkopp
2025-09-10 7:40 ` Vincent Mailhol
2025-09-10 8:48 ` Oliver Hartkopp
2025-09-10 16:19 ` Vincent Mailhol [this message]
2025-09-10 20:12 ` Oliver Hartkopp
2025-09-15 10:55 ` Vincent Mailhol
2025-09-15 13:59 ` Vincent Mailhol
2025-09-15 18:08 ` Oliver Hartkopp
2025-09-15 18:54 ` Vincent Mailhol
2025-09-16 9:14 ` Oliver Hartkopp
2025-09-16 13:17 ` Vincent Mailhol
2025-09-17 21:29 ` Oliver Hartkopp
2025-09-18 9:18 ` Vincent Mailhol
2025-09-20 17:38 ` Oliver Hartkopp
2025-09-20 17:57 ` Vincent Mailhol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6637b79-6377-4038-967f-0354a32eb2c3@kernel.org \
--to=mailhol@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox