Linux CAN drivers development
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Lee Jones <lee@kernel.org>, Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] can: bcm: prevent thrtimer UAF in rx path by checking RX_NO_AUTOTIMER
Date: Tue, 28 Apr 2026 11:32:53 +0200	[thread overview]
Message-ID: <b96cce17-abfa-41b9-9a9f-a34454fec4d8@hartkopp.net> (raw)
In-Reply-To: <20260428085739.GB8212@google.com>



On 28.04.26 10:57, Lee Jones wrote:
> On Mon, 27 Apr 2026, Marc Kleine-Budde wrote:
> 
>> On 27.04.2026 19:15:29, Oliver Hartkopp wrote:
>>>>> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
>>>>
>>>> I'm a little confused by the SoB.  Does this mean you've applied it?
>>>>
>>>
>>> No. Marc will apply the patch.
>>>
>>> My SoB is probably not needed in this context.
>>
>> ACK
>>
>>> But Marc was sometimes asking
>>> for it when I commented and discussed patches in the past.
>>
>> The rule is: if you post a patch, your S-o-b has to be the last S-o-b in
>> the line.
> 
> Right.  But SoBs are an indicator that a given person was part of the
> patch flow; author, submitter, sub-maintainer, maintainer, etc.
> 
> In this context Oliver's SoB should have been Reviewed-by or Acked-by.
> 

Yes.

I'm author and maintainer of the bcm code - but Marc manages the patch 
flow for the CAN subsystem. That's why I sent my Acked-by instantly - 
which was the right reaction. Sorry for the SoB noise.

Many thanks,
OLiver


  reply	other threads:[~2026-04-28  9:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22 10:22 [PATCH 1/1] can: bcm: prevent thrtimer UAF in rx path by checking RX_NO_AUTOTIMER Lee Jones
2026-04-22 12:55 ` Oliver Hartkopp
2026-04-24 19:08   ` Marc Kleine-Budde
2026-04-25  6:49     ` Oliver Hartkopp
2026-04-27 12:40       ` Lee Jones
2026-04-27 17:15         ` Oliver Hartkopp
2026-04-27 17:41           ` Marc Kleine-Budde
2026-04-27 17:58             ` Oliver Hartkopp
2026-04-28  8:57             ` Lee Jones
2026-04-28  9:32               ` Oliver Hartkopp [this message]
2026-05-05 14:42             ` Lee Jones
2026-05-06 12:45 ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b96cce17-abfa-41b9-9a9f-a34454fec4d8@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=lee@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox