Re: CAN implementation on A20 Allwinner

[Gerhard Bertelsmann <info@gerhard-bertelsmann.de>]

Hi Marc,

many thx for your fast answer.

Am 2015-08-27 15:23, schrieb Marc Kleine-Budde:
> On 08/27/2015 03:04 PM, Gerhard Bertelsmann wrote:
>>> It it's sja1000 compatible, it should work out of the box with the
>>> existing sja1000 device tree binding.
>> 
>> the Allwinner CAN IP is very similar but not exactly a SJA1000, e g. 
>> the
>> registers differ and some are 32 bit wide and not 8 bit.
> 
> Which are the registers that have the upper 24 bit used?

CAN_STA_REG  status register
CAN_BUS_TIME bus timing
CAN_REC_REG  errot counter

Some regs also have a different address

> 
>> So the question is: change the sja1000 and the platform file for
>> "quirks" or write a new independent one ?
> 
> Depends on the actual differences, but I'd go for quirks first.
> 
>> Which way do you prefer or better: which driver will be accepted for
>> mainline ?
> 
> The github driver lacks a proper driver model binding, so that's not
> mainline ready.

That would be not a huge problem IMHO ...

> 
> Marc

Gerd