From: Jacob Kroon <jacob.kroon@gmail.com>
To: Oliver Hartkopp <socketcan@hartkopp.net>,
linux-can@vger.kernel.org, wg@grandegger.com, mkl@pengutronix.de
Subject: Re: CM-ITC, pch_can/c_can_pci, sendto() returning ENOBUFS
Date: Fri, 2 Sep 2022 17:13:46 +0200 [thread overview]
Message-ID: <c1c8bbbe-4282-1dc4-db20-a21b55eecc14@gmail.com> (raw)
In-Reply-To: <68dd96fb-69e7-d82f-75b3-610afe9ae0b8@hartkopp.net>
Hi Oliver,
On 9/1/22 18:35, Oliver Hartkopp wrote:
> Hi Jacob,
>
> On 01.09.22 11:38, Jacob Kroon wrote:
>> On 8/30/22 21:15, Oliver Hartkopp wrote:
>
>>> I assume you have a transceiver, right? ;-)
>>>
>>
>> Yes,, all nodes are using a TJA1050 transceiver
>> (https://www.nxp.com/docs/en/data-sheet/TJA1050.pdf)
>
> Good!
>
>>> What is the other endpoint? The EG20T and another (automotive) ECU?
>>
>> Currently I have 4 nodes in the network, EG20T is in one end.
>>
>
> Ok, that's a good base for testing.
>
>>>>> Do you have another CAN node which can be attached to the EG20T
>>>>> setup (e.g. some ECU or an USB CAN adapter)?
>>>>
>>>> Yes I do have a CAN analyser from Microchip. I guess I can record
>>>> all traffic with the analyzer, and compare it to what I see with
>>>> "candump can0" on the host. Or do you have some other suggestion ?
>>>
>>> Yes, please add the CAN analyzer from Microchip too!
>>>
>>> The problem with only two nodes is that you have to be very precise
>>> with bitrate settings and sampling points so that the receiving node
>>> needs to properly set the ACK to acknowlege the CAN frame.
>>>
>>> I had been working with a MSCAN system some time ago and that wasn't
>>> able to talk to a commercial CAN tool until I added another node
>>> (from another CAN tool provider).
>>>
>>> Maybe you can make the other node talk to the Microchip CAN analyzer
>>> and let the EG20T receive that traffic first.
>>>
>>
>> I used "candump can0 -l" on the EG20T host to capture the traffic, and
>> then connected an CAN USB analyzer to the network and used that to
>> capture the traffic. One thing sticks out. This is the log from the
>> CAN USB analyzer:
>>
>>> ...
>>> 505.7052;RX;0x464;3;0x01;0x01;0x00;;;;;;
>>> 505.7052;RX;0x464;3;0x00;0x00;0x00;;;;;;
>>> 505.7063;RX;0x65;64;;;;;;;;;
>
> What should this be?
>
> A length of 64 and no data ??
>
> This is no valid CAN frame.
>
>>> 505.7662;RX;0x440;3;0x32;0x20;0xFA;;;;;;
> (..)
>
>>
>> Note the third message from the top. This is what "candump" on the
>> host logs:
>>
>>> ...
>>> (1662022485.638794) can0 464#010100
>>> (1662022485.638940) can0 464#000000
>>> (1662022485.699405) can0 440#3220FA
>
> The correct CAN frames are displayed correctly.
>
>>> ...
>>
>> It fails to see the 3rd message from the previous log. What would that
>> indicate ? The CAN analyzer sees the message, but the EG20T doesn't.
>
> Don't know if this is an error on the CAN bus. You can also print error
> messages of detected CAN bus problems with adding an error message filter.
>
> See 'candump -h' :
>
> candump -l any,0:0,#FFFFFFFF
> (log error frames and also all data frames)
>
>
Thank you Oliver for all the good hints.
I've done some more logging, but there are no error frames being logged.
I can see that both pch_can and c_can_pci drivers call
can_put_echo_skb() in their ndo_start_xmit functions, but neither checks
the return value whether it succeeded or not. Shouldn't both these
return NETDEV_TX_BUSY if there are no echo slots available ?
One reason I ask is because whenever I strace the application, it would
seem the problem goes away, and I'm guessing strace:ing will slow down
my application.
Regards
Jacob
next prev parent reply other threads:[~2022-09-02 15:32 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 13:25 CM-ITC, pch_can/c_can_pci, sendto() returning ENOBUFS Jacob Kroon
2022-08-26 11:24 ` Jacob Kroon
2022-08-29 9:14 ` Jacob Kroon
2022-08-29 13:20 ` Jacob Kroon
2022-08-29 13:53 ` Oliver Hartkopp
2022-08-30 12:59 ` Jacob Kroon
2022-08-30 19:15 ` Oliver Hartkopp
2022-09-01 9:38 ` Jacob Kroon
2022-09-01 16:35 ` Oliver Hartkopp
2022-09-02 15:13 ` Jacob Kroon [this message]
2022-09-02 16:39 ` Jacob Kroon
2022-09-05 14:17 ` Marc Kleine-Budde
2022-09-05 15:54 ` Marc Kleine-Budde
2022-09-16 4:14 ` Jacob Kroon
2022-09-19 23:24 ` Jacob Kroon
2022-09-20 1:23 ` Vincent Mailhol
2022-09-20 5:08 ` Jacob Kroon
2022-09-21 7:25 ` dariobin
2022-09-21 7:47 ` Marc Kleine-Budde
2022-09-21 8:26 ` Jacob Kroon
2022-09-21 9:55 ` Oliver Hartkopp
2022-09-21 10:32 ` Marc Kleine-Budde
2022-09-21 10:39 ` Oliver Hartkopp
2022-09-21 10:53 ` Marc Kleine-Budde
2022-09-21 11:00 ` Oliver Hartkopp
2022-09-22 7:20 ` dariobin
2022-09-23 11:36 ` Marc Kleine-Budde
2022-09-23 17:55 ` dariobin
2022-09-23 19:03 ` Jacob Kroon
2022-09-23 19:21 ` Jacob Kroon
2022-09-23 19:45 ` dariobin
2022-09-23 20:27 ` Jacob Kroon
2022-09-24 5:17 ` Jacob Kroon
2022-09-28 8:25 ` Marc Kleine-Budde
2022-09-28 8:28 ` Jacob Kroon
2022-09-28 8:02 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1c8bbbe-4282-1dc4-db20-a21b55eecc14@gmail.com \
--to=jacob.kroon@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox