From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, NXP Linux Team <s32@nxp.com>,
Christophe Lizzi <clizzi@redhat.com>,
Alberto Ruiz <aruizrui@redhat.com>,
Enric Balletbo <eballetb@redhat.com>
Subject: Re: [PATCH 1/3] dt-bindings: can: fsl,flexcan: add S32G2/S32G3 SoC support
Date: Wed, 20 Nov 2024 12:33:52 +0200 [thread overview]
Message-ID: <cc38915f-bd91-413c-93fc-4f1a5f3b1541@oss.nxp.com> (raw)
In-Reply-To: <5527f0e2-1986-4eb5-b16a-86276db0cbb5@kernel.org>
On 11/20/2024 11:12 AM, Krzysztof Kozlowski wrote:
> On 20/11/2024 09:45, Krzysztof Kozlowski wrote:
>> On Tue, Nov 19, 2024 at 10:10:51AM +0200, Ciprian Costea wrote:
>>> reg:
>>> maxItems: 1
>>> @@ -136,6 +138,23 @@ required:
>>> - reg
>>> - interrupts
>>>
>>> +allOf:
>>> + - $ref: can-controller.yaml#
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + const: nxp,s32g2-flexcan
>>> + then:
>>> + properties:
>>> + interrupts:
>>> + minItems: 4
>>> + maxItems: 4
>>
>> Top level says max is 1. You need to keep there widest constraints.
> And list items here instead...
>
> Best regards,
> Krzysztof
Hello Krzysztof,
Just to confirm before making any changes:
Are you referring to directly change 'maxItems' to value 4 ? Instead of
using this 'if' condition under 'allOf' ?
Best Regards,
Ciprian
next prev parent reply other threads:[~2024-11-20 10:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 8:10 [PATCH 0/3] add FlexCAN support for S32G2/S32G3 SoCs Ciprian Costea
2024-11-19 8:10 ` [PATCH 1/3] dt-bindings: can: fsl,flexcan: add S32G2/S32G3 SoC support Ciprian Costea
2024-11-19 19:49 ` Frank Li
2024-11-20 8:45 ` Krzysztof Kozlowski
2024-11-20 9:12 ` Krzysztof Kozlowski
2024-11-20 10:33 ` Ciprian Marian Costea [this message]
2024-11-20 13:29 ` Krzysztof Kozlowski
2024-11-20 8:49 ` Marc Kleine-Budde
2024-11-20 9:04 ` Ciprian Marian Costea
2024-11-19 8:10 ` [PATCH 2/3] can: flexcan: add NXP " Ciprian Costea
2024-11-19 19:50 ` Frank Li
2024-11-20 9:01 ` Marc Kleine-Budde
2024-11-20 9:16 ` Ciprian Marian Costea
2024-11-19 8:10 ` [PATCH 3/3] can: flexcan: handle S32G2/S32G3 separate interrupt lines Ciprian Costea
2024-11-19 9:26 ` Vincent Mailhol
2024-11-19 10:01 ` Ciprian Marian Costea
2024-11-19 11:26 ` Vincent Mailhol
2024-11-19 11:28 ` Marc Kleine-Budde
2024-11-19 11:36 ` Vincent Mailhol
2024-11-19 11:40 ` Ciprian Marian Costea
2024-11-20 8:52 ` Marc Kleine-Budde
2024-11-20 9:01 ` Ciprian Marian Costea
2024-11-20 10:01 ` Marc Kleine-Budde
2024-11-20 10:18 ` Ciprian Marian Costea
2024-11-20 10:29 ` Marc Kleine-Budde
2024-11-20 10:47 ` Ciprian Marian Costea
2024-11-20 10:54 ` Marc Kleine-Budde
2024-11-20 11:02 ` Ciprian Marian Costea
2024-11-20 11:33 ` Marc Kleine-Budde
2024-11-20 11:42 ` Ciprian Marian Costea
2024-11-20 12:06 ` Marc Kleine-Budde
2024-11-20 12:20 ` Marc Kleine-Budde
2024-11-20 13:38 ` Ciprian Marian Costea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc38915f-bd91-413c-93fc-4f1a5f3b1541@oss.nxp.com \
--to=ciprianmarian.costea@oss.nxp.com \
--cc=andrew+netdev@lunn.ch \
--cc=aruizrui@redhat.com \
--cc=clizzi@redhat.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=eballetb@redhat.com \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=s32@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox