From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Reyders Morales <reyders1@gmail.com>, kuba@kernel.org
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation/networking: Fix basic node example document ISO 15765-2
Date: Tue, 4 Feb 2025 08:40:29 +0100 [thread overview]
Message-ID: <d63b3475-c423-4167-806b-97f22258cb07@hartkopp.net> (raw)
In-Reply-To: <20250203224720.42530-1-reyders1@gmail.com>
On 03.02.25 23:47, Reyders Morales wrote:
> In the current struct sockaddr_can tp is member of can_addr.
> tp is not member of struct sockaddr_can.
>
> Signed-off-by: Reyders Morales <reyders1@gmail.com>
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Thanks!
> ---
> Documentation/networking/iso15765-2.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/networking/iso15765-2.rst b/Documentation/networking/iso15765-2.rst
> index 0e9d96074178..37ebb2c417cb 100644
> --- a/Documentation/networking/iso15765-2.rst
> +++ b/Documentation/networking/iso15765-2.rst
> @@ -369,8 +369,8 @@ to their default.
>
> addr.can_family = AF_CAN;
> addr.can_ifindex = if_nametoindex("can0");
> - addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
> - addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
> + addr.can_addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
> + addr.can_addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
>
> ret = bind(s, (struct sockaddr *)&addr, sizeof(addr));
> if (ret < 0)
next prev parent reply other threads:[~2025-02-04 7:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 22:47 [PATCH] Documentation/networking: Fix basic node example document ISO 15765-2 Reyders Morales
2025-02-04 7:40 ` Oliver Hartkopp [this message]
2025-02-04 13:45 ` Simon Horman
2025-02-06 8:02 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d63b3475-c423-4167-806b-97f22258cb07@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=reyders1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox