From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 2/2] dt-bindings: Remove cases of 'allOf' containing a '$ref' Date: Wed, 15 Apr 2020 23:49:40 -0700 Message-ID: References: <20200416005549.9683-1-robh@kernel.org> <20200416005549.9683-2-robh@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200416005549.9683-2-robh@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=m.gmane-mx.org@lists.infradead.org To: Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andrew Lunn , Ulf Hansson , Heiko Stuebner , Sam Ravnborg , linux-iio@vger.kernel.org, linux-pci@vger.kernel.org, Linus Walleij , linux-remoteproc@vger.kernel.org, Alexandre Belloni , dri-devel@lists.freedesktop.org, Bjorn Andersson , Thierry Reding , linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, Pavel Machek , linux-riscv@lists.infradead.org, Lee Jones , linux-clk@vger.kernel.org, linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org, Florian Fainelli , Fabio Estevam , Daniel Lezcano , Krzysztof Kozlowski , Bartosz Golaszewski List-Id: linux-can.vger.kernel.org On Wed, 2020-04-15 at 19:55 -0500, Rob Herring wrote: > json-schema versions draft7 and earlier have a weird behavior in that > any keywords combined with a '$ref' are ignored (silently). The correct > form was to put a '$ref' under an 'allOf'. This behavior is now changed > in the 2019-09 json-schema spec and '$ref' can be mixed with other > keywords. The json-schema library doesn't yet support this, but the > tooling now does a fixup for this and either way works. > > This has been a constant source of review comments, so let's change this > treewide so everyone copies the simpler syntax. This is a large change. Was this done manually or by some script? If it was done manually, how likely is it there are defects in the conversion? ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/