From: Vincent Mailhol <mailhol@kernel.org>
To: Oliver Hartkopp <socketcan@hartkopp.net>, linux-can@vger.kernel.org
Subject: Re: [PATCH v2] dummy_can: fix packet statistics
Date: Mon, 26 Jan 2026 19:39:46 +0100 [thread overview]
Message-ID: <dcd84641-e4bc-405b-ad0b-03dd60fd9e9a@kernel.org> (raw)
In-Reply-To: <20260126104540.21024-1-socketcan@hartkopp.net>
On 26/01/2026 at 11:45, Oliver Hartkopp wrote:
> The former implementation was only counting the tx_packets value but not
> the tx_bytes as the skb was dropped on driver layer.
> By enabling the CAN echo support (IFF_ECHO) in dummy_can_init() the code
> to put and get the echo skb is activated and the tx_bytes are counted
> correctly.
>
> Fixes: 816cf430e84b ("can: add dummy_can driver")
> Cc: Vincent Mailhol <mailhol@kernel.org>
> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Reviewed-by: Vincent Mailhol <mailhol@kernel.org>
Yours sincerely,
Vincent Mailhol
next prev parent reply other threads:[~2026-01-26 18:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 10:45 [PATCH v2] dummy_can: fix packet statistics Oliver Hartkopp
2026-01-26 18:39 ` Vincent Mailhol [this message]
2026-01-27 15:25 ` Marc Kleine-Budde
2026-01-27 15:34 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcd84641-e4bc-405b-ad0b-03dd60fd9e9a@kernel.org \
--to=mailhol@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox