From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F5FE29A1 for ; Mon, 26 Jan 2026 18:39:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769452790; cv=none; b=ROI36z9nt/YsLzut1iTLHOagrSCUuS551/XdCFwP56ylhdtYH/RNn8pYXPDZYASbwTnr62g9UMonO5Du9Hsxqo4DIO7MxmH6p9CBpwXsoyGo2cO0U0w46G4TJ6F+/oLXQxduVmmc2aDZxXRGkI8UWuy3ihxkSxqgp10bC2gW8K4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769452790; c=relaxed/simple; bh=kSO0AThG3oYr+/FQYaVQPJPjbVZUHwsGousW8FtfYSQ=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=hrJIKNmS1f70ktqa1EYsDuTE6ax6twUBUNRcwZMzer+96dybH4jx0ZeBRKF31UiZRCn7nEIt8dA2mJkceOy6rya/va1FhSU/Kzfno05Xi4ws+AL2UI10/CiGHmFJXW64I9ajVfYzPWrA2CDwnzABJa8HHN0XwixaIE8iy2/PQP0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lgbXkuTy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lgbXkuTy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BD6FC116C6; Mon, 26 Jan 2026 18:39:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769452790; bh=kSO0AThG3oYr+/FQYaVQPJPjbVZUHwsGousW8FtfYSQ=; h=Date:Subject:To:References:From:In-Reply-To:From; b=lgbXkuTyQBOVuVeH0M/t7oINf2eMULHKu5t4+VP6dKrDWt7lm4WWS4l1KahLNhnCd FBLL2SlAhFL/YpSNO/a1UWjYn4RHu/AsFm4qi5MlaoeQ5jg/71L/LT3cqWiZSuFRyk x8+6cKWsBYb4DAdTU7wc/76AKYwr4NJtJxdoS8wvX15Njg+W7pGc+k7rcLSpEy7vCl QkY9NZ9DfY3wELFLOUnAtu9HEV8K4lWJ86zcR2LuCS8ZYTUUUck9iVO48eFX6F9xGg NlpVJWzFKlnAuJILyfICdU8exHuq91yxHUksOBNzc6rQMi4DhrTf3GCg+Lvd/yjp0a dIXDBbfNc/ITA== Message-ID: Date: Mon, 26 Jan 2026 19:39:46 +0100 Precedence: bulk X-Mailing-List: linux-can@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] dummy_can: fix packet statistics To: Oliver Hartkopp , linux-can@vger.kernel.org References: <20260126104540.21024-1-socketcan@hartkopp.net> From: Vincent Mailhol Content-Language: en-US Autocrypt: addr=mailhol@kernel.org; keydata= xjMEZluomRYJKwYBBAHaRw8BAQdAf+/PnQvy9LCWNSJLbhc+AOUsR2cNVonvxhDk/KcW7FvN JFZpbmNlbnQgTWFpbGhvbCA8bWFpbGhvbEBrZXJuZWwub3JnPsKZBBMWCgBBFiEE7Y9wBXTm fyDldOjiq1/riG27mcIFAmdfB/kCGwMFCQp/CJcFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcC F4AACgkQq1/riG27mcKBHgEAygbvORJOfMHGlq5lQhZkDnaUXbpZhxirxkAHwTypHr4A/joI 2wLjgTCm5I2Z3zB8hqJu+OeFPXZFWGTuk0e2wT4JzjgEZx4y8xIKKwYBBAGXVQEFAQEHQJrb YZzu0JG5w8gxE6EtQe6LmxKMqP6EyR33sA+BR9pLAwEIB8J+BBgWCgAmFiEE7Y9wBXTmfyDl dOjiq1/riG27mcIFAmceMvMCGwwFCQPCZwAACgkQq1/riG27mcJU7QEA+LmpFhfQ1aij/L8V zsZwr/S44HCzcz5+jkxnVVQ5LZ4BANOCpYEY+CYrld5XZvM8h2EntNnzxHHuhjfDOQ3MAkEK In-Reply-To: <20260126104540.21024-1-socketcan@hartkopp.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 26/01/2026 at 11:45, Oliver Hartkopp wrote: > The former implementation was only counting the tx_packets value but not > the tx_bytes as the skb was dropped on driver layer. > By enabling the CAN echo support (IFF_ECHO) in dummy_can_init() the code > to put and get the echo skb is activated and the tx_bytes are counted > correctly. > > Fixes: 816cf430e84b ("can: add dummy_can driver") > Cc: Vincent Mailhol > Signed-off-by: Oliver Hartkopp Reviewed-by: Vincent Mailhol Yours sincerely, Vincent Mailhol