RE: [PATCH v2 0/3] can: gs_usb: cleanups and termination support

["Trevitz, Daniel" <Daniel.Trevitz@wika.com>]

Is there a place to document this?

Example setting termination state:
	on: ip link set dev can0 type can termination 120
	off: ip link set dev can0 type can termination 0

Read the state:
	ip -details link show can0 

58: can0: <NOARP,ECHO> mtu 16 qdisc noop state DOWN mode DEFAULT group default qlen 10
    link/can  promiscuity 0 minmtu 0 maxmtu 0 
    can state STOPPED restart-ms 0 
          gs_usb: tseg1 1..16 tseg2 1..8 sjw 1..4 brp 1..1024 brp_inc 1
          termination 120 [ 0, 120
          clock 48000000 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535 gro_max_size 65536 parentbus usb parentdev 3-12.2:1.0





**CONFIDENTIALITY NOTICE**


This communication, including any attachments, is from WIKA Mobile Control, LP and contains confidential information intended only for the addressee(s). If you are not the intended recipient, any use, dissemination, distribution or copying of this document or its contents is strictly prohibited. If you have received this communication in error, please contact the sender by reply e-mail immediately and destroy all copies of the original message. 


-----Original Message-----
From: Marc Kleine-Budde <mkl@pengutronix.de> 
Sent: Sunday, September 18, 2022 5:18 PM
To: linux-can@vger.kernel.org
Cc: Trevitz, Daniel <Daniel.Trevitz@wika.com>; Ryan Edwards <ryan.edwards@gmail.com>
Subject: [PATCH v2 0/3] can: gs_usb: cleanups and termination support


Hello,

this series first cleans up the driver a bit and then adds switchable termination support.

regards,
Marc

changes since v1 https://lore.kernel.org/all/20220918202348.675850-1-mkl@pengutronix.de:
- add 1/3: "can: gs_usb: gs_make_candev(): convert from usb_control_msg() to usb_control_msg_recv()"
  to make error handling easier
- add 2/3: "can: gs_usb: gs_make_candev(): clean up error handling"
  which introduces a cleanup label
- move 1/3 to 3/3:
  - fix gs_usb_get_termination(), set term value
  - remove check of termination value from gs_usb_set_termination()
  - check for initial termination in gs_make_candev()