From: Marek Vasut <marex@denx.de>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
Heiko Schocher <hs@denx.de>,
linux-can@vger.kernel.org
Cc: Markus Marb <markus@marb.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Wolfgang Grandegger <wg@grandegger.com>
Subject: Re: [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error
Date: Thu, 8 Feb 2018 20:22:54 +0100 [thread overview]
Message-ID: <dfae1bda-9ccd-6a48-95f9-e061c1bd3828@denx.de> (raw)
In-Reply-To: <59322f7d-4207-a5a4-89b5-dff1634e4183@pengutronix.de>
On 02/08/2018 03:46 PM, Marc Kleine-Budde wrote:
> On 02/08/2018 07:47 AM, Heiko Schocher wrote:
>> the driver reads in the ISR first the IRQpending register,
>> and clears after that in a write *all* bits in it.
>>
>> It could happen that the isr register raise bits between
>> this 2 register accesses, which leads in lost bits ...
>>
>> In case it clears "TX message sent successfully", the driver
>> never sends any Tx data, and buffers to userspace run over.
>>
>> Fixed this:
>> clear only the bits in the IRQpending register, the
>> driver had read.
>>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> Reviewed-by: Marek Vasut <marex@denx.de>
>
> Applied both to linux-can.
Can you also apply them to stable, so they get into 4.9.x etc ?
Thanks!
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2018-02-08 20:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 6:47 [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error Heiko Schocher
2018-02-08 6:47 ` [PATCH v2 2/2] net, can, ifi: loopback Tx message in IFI block Heiko Schocher
2018-02-08 14:46 ` [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error Marc Kleine-Budde
2018-02-08 19:22 ` Marek Vasut [this message]
2018-02-08 21:33 ` Marc Kleine-Budde
2018-02-08 21:44 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfae1bda-9ccd-6a48-95f9-e061c1bd3828@denx.de \
--to=marex@denx.de \
--cc=hs@denx.de \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@marb.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox