Linux CAN drivers development
 help / color / mirror / Atom feed
From: "Prückl Thomas" <T.Prueckl@hainzl.at>
To: "rcsekar@samsung.com" <rcsekar@samsung.com>,
	"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: net: m_can: missing mutexes in tx_work_queue and isr-handler
Date: Tue, 10 Dec 2024 09:02:37 +0000	[thread overview]
Message-ID: <f6a9e128fbc04dcebd70e9b254b344e2@hainzl.at> (raw)

Hi Chandrasekar,

I'm using the m_can driver with the externals TCAN4550-Q1 can controller (SPI) on an IMX8MN controller.
After some time the driver stops working.

After reviewing the driver (m_can.c) I noticed that there are not mutex locks preventing concurrent access of 
m_can_isr and m_can_tx_work_queue.

After I added mutex_lock in these functions the driver was working fine.

Is the driver really missing the locking or is it done on another level?

Yours sincerely,
Thomas Prueckl

             reply	other threads:[~2024-12-10  9:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-10  9:02 Prückl Thomas [this message]
2024-12-10 13:27 ` net: m_can: missing mutexes in tx_work_queue and isr-handler Marc Kleine-Budde
2024-12-10 15:04   ` AW: " Prückl Thomas
2024-12-18 12:07     ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6a9e128fbc04dcebd70e9b254b344e2@hainzl.at \
    --to=t.prueckl@hainzl.at \
    --cc=linux-can@vger.kernel.org \
    --cc=rcsekar@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox