From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Srinivas Goud <srinivas.goud@amd.com>,
wg@grandegger.com, mkl@pengutronix.de, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, p.zabel@pengutronix.de
Cc: git@amd.com, michal.simek@amd.com, linux-can@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, gcnu.goud@gmail.com
Subject: Re: [PATCH v2 1/3] dt-bindings: can: xilinx_can: Add ECC property ‘xlnx,has-ecc’
Date: Tue, 22 Aug 2023 21:30:32 +0200 [thread overview]
Message-ID: <fff772d3-a5c7-77c1-c372-22b2313ee622@linaro.org> (raw)
In-Reply-To: <1692701136-1422086-2-git-send-email-srinivas.goud@amd.com>
On 22/08/2023 12:45, Srinivas Goud wrote:
> ECC feature added to Tx and Rx FIFO’s for Xilinx CAN Controller.
> Part of this feature configuration and counter registers added in
> IP for 1bit/2bit ECC errors.
>
> xlnx,has-ecc is optional property and added to Xilinx CAN Controller
> node if ECC block enabled in the HW
>
Second time the same mistake... and I spoke about this mistake twice:
1.
https://lore.kernel.org/all/78b104cd-15a2-63d8-bbce-0a5593e6a151@kernel.org/
2.
https://lore.kernel.org/all/aed1592f-927f-13ab-b692-7a0745ac5733@kernel.org/
I don't understand why this is so difficult... automation solves all the
problems, there is no manual work here. :/
Anyway, standard text:
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.
Please kindly resend and include all necessary To/Cc entries.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-22 19:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 10:45 [PATCH v2 0/3] can: xilinx_can: Add ECC feature support Srinivas Goud
2023-08-22 10:45 ` [PATCH v2 1/3] dt-bindings: can: xilinx_can: Add ECC property ‘xlnx,has-ecc’ Srinivas Goud
2023-08-22 19:30 ` Krzysztof Kozlowski [this message]
2023-08-22 10:45 ` [PATCH v2 2/3] can: xilinx_can: Add ECC support Srinivas Goud
2023-08-22 10:45 ` [PATCH v2 3/3] can: xilinx_can: Add ethtool stats interface for ECC errors Srinivas Goud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fff772d3-a5c7-77c1-c372-22b2313ee622@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gcnu.goud@gmail.com \
--cc=git@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=mkl@pengutronix.de \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.goud@amd.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox