From: Richard Andrysek <richard.andrysek@rg-mechatronics.com>
To: linux-can@vger.kernel.org
Subject: Re: [PATCH v6] can: sja1000: fix {pre,post}_irq() handling and IRQ handler return value
Date: Mon, 9 Dec 2013 09:29:23 +0000 (UTC) [thread overview]
Message-ID: <loom.20131209T101448-258@post.gmane.org> (raw)
In-Reply-To: 52A21837.3030709@grandegger.com
Wolfgang Grandegger <wg <at> grandegger.com> writes:
>
> On 12/06/2013 11:32 AM, Richard Andrysek wrote:
> > Wolfgang Grandegger <wg <at> grandegger.com> writes:
> >
> >>
> >> ...
> >>
> >>> I've just studied sja1000.c I do not know yet, if it is healthy.
> >>
> >> This is normally due to hardware/electrical problems. It has nothing to do
> >>
> >> with software. Well, is there *any* relation to the patch mentioned in the
> >>
> >> subject? I mean, does the problem *not* show up without that patch.
> >
> >
> > Patch solved a problem with unhandled IRQs. The original problem is solved.
>
> What did it fix? Could you elaborate on that issue. You actually never
> reported a problem.
>
> Wolfgang.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-can" in
> the body of a message to majordomo <at> vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
I've reported a problem by peak-systems and they recommend me this patch.
Without this patch with gotos, it leaves unhandled IRQs, e.g.:
Dec 1 04:59:33 xxx kernel: [141189.277965] irq 19: nobody cared (try
booting with the "irqpoll" option)
...
Dec 1 04:59:33 xxx kernel: [141189.278131] Disabling IRQ #19
With this patch the sja1000 IRQs are not lost.
next prev parent reply other threads:[~2013-12-09 9:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-24 23:03 [PATCH v6] can: sja1000: fix {pre,post}_irq() handling and IRQ handler return value Marc Kleine-Budde
2013-11-25 8:54 ` Marc Kleine-Budde
2013-11-25 18:12 ` Oliver Hartkopp
2013-11-25 22:05 ` Austin Schuh
2013-12-09 19:48 ` Austin Schuh
2013-12-09 21:07 ` Marc Kleine-Budde
2013-12-09 23:50 ` Austin Schuh
2013-12-05 15:50 ` Richard Andrysek
2013-12-05 17:50 ` Wolfgang Grandegger
2013-12-05 19:37 ` Richard Andrysek
2013-12-05 20:26 ` Wolfgang Grandegger
2013-12-06 9:27 ` Richard Andrysek
2013-12-06 9:56 ` Wolfgang Grandegger
2013-12-06 10:32 ` Richard Andrysek
2013-12-06 18:32 ` Wolfgang Grandegger
2013-12-09 9:29 ` Richard Andrysek [this message]
2013-12-06 10:12 ` Marc Kleine-Budde
2013-12-06 10:57 ` Richard Andrysek
2013-12-06 11:45 ` arbitration lost error reporting (was: Re: [PATCH v6] can: sja1000: fix {pre,post}_irq() handling and IRQ handler return value) Marc Kleine-Budde
2013-12-06 12:02 ` arbitration lost error reporting Oliver Hartkopp
2013-12-06 12:16 ` Marc Kleine-Budde
2013-12-06 13:21 ` Richard Andrysek
2013-12-06 13:23 ` Marc Kleine-Budde
2013-12-06 17:59 ` Wolfgang Grandegger
2013-12-07 13:13 ` Oliver Hartkopp
2013-12-09 9:01 ` Richard Andrysek
2013-12-09 10:32 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20131209T101448-258@post.gmane.org \
--to=richard.andrysek@rg-mechatronics.com \
--cc=linux-can@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).