Re: [PATCH net-next 16/37] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3L SoC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] dt-bindings: missing resets requirement for renesas,r9a08g046-canfd
- [Low] dt-bindings: can: missing maxItems constraint for r9a08g046-canfd interrupts
--

commit 36441ccce0b87ca8f2e74ff4324b679b4b9479d1
Author: Biju Das <biju.das.jz@bp.renesas.com>

dt-bindings: can: renesas,rcar-canfd: Document RZ/G3L SoC

This commit documents the RZ/G3L (R9A08G046) SoC support. It specifies the
new compatible string along with its unique hardware constraints, including
limits for interrupts and CANFD channels.

Link: https://patch.msgid.link/20261001075742.21961-2-biju.das.jz@bp.renesas.com

> diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> index bbaaef8f4282e..cef20f0403715 100644
> --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml

[ ... ]

> @@ -292,6 +293,25 @@ allOf:
>        patternProperties:
>          "^channel[6-7]$": false
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: renesas,r9a08g046-canfd
> +    then:
> +      properties:
> +        interrupts:
> +          minItems: 11
> +
> +        interrupt-names:
> +          minItems: 11
> +

[Severity: Low]
Does this block also need maxItems: 11 for interrupts and interrupt-names?

The root schema defines a list of up to 20 interrupt items. Without an
explicit maxItems constraint in this conditional block, it appears device
trees could define up to 20 interrupts and still pass validation, missing
the enforcement of the 11-interrupt hardware limit.

> +        resets:
> +          minItems: 2
> +

[Severity: Medium]
Since this variant specifies resets constraints, should
renesas,r9a08g046-canfd also be added to the existing allOf block that
enforces resets and reset-names as required properties?

There is an existing conditional block in this file that requires these
properties for related variants:

  - if:
      properties:
        compatible:
          contains:
            enum:
              - renesas,r9a08g045-canfd
              - renesas,r9a09g047-canfd
              - renesas,rzg2l-canfd
    then:
      required:
        - resets
        - reset-names

Omitting the new variant from this shared block means device tree nodes for
the RZ/G3L variant missing the mandatory resets and reset-names properties
will silently pass schema validation.

> +      patternProperties:
> +        "^channel[3-7]$": false

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009134323.64064-1-mkl@pengutronix.de?part=16