Re: [PATCH net-next 19/37] dt-bindings: can: renesas,rcar-canfd: Document RZ/G3L SoC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] dt-bindings: missing required resets and reset-names for RZ/G3L
- [Medium] dt-bindings: missing maxItems constraint for RZ/G3L interrupts
--

commit 58ac9c18cd2ddefc0f54df00f420c9a823c995ac
Author: Biju Das <biju.das.jz@bp.renesas.com>

dt-bindings: can: renesas,rcar-canfd: Document RZ/G3L SoC

Document the RZ/G3L (R9A08G046) SoC support. RZ/G3L has 11 interrupts and
3 CANFD channels compared to 8 interrupts and 2 CANFD channels on RZ/G3S.
RZ/G3L has 288 buffers in total compared to 192 buffers in RZ/G3S.

Link: https://patch.msgid.link/20261001075742.21961-2-biju.das.jz@bp.renesas.com

> diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> index 1a7a9ce45e977..4b94bc8d911be 100644
> --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml

[ ... ]

> @@ -294,6 +295,25 @@ allOf:
>        patternProperties:
>          "^channel[6-7]$": false
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: renesas,r9a08g046-canfd
> +    then:
> +      properties:
> +        interrupts:
> +          minItems: 11

[Severity: Medium]
Does this block also need a maxItems constraint?

The top-level schema permits up to 20 interrupts by default. While this
block correctly specifies minItems: 11, it omits maxItems: 11.

Could a devicetree node providing between 12 and 20 interrupts silently
pass schema validation instead of being properly rejected?

> +
> +        interrupt-names:
> +          minItems: 11
> +
> +        resets:
> +          minItems: 2

[Severity: Medium]
Should the new compatible string be added to the shared required properties block?

This block indicates the hardware requires 2 resets. However, the new
compatible string was not added to the existing shared if-then block that
enforces resets and reset-names as required properties:

  - if:
      properties:
        compatible:
          contains:
            enum:
              - renesas,r9a08g045-canfd
              - renesas,r9a09g047-canfd
              - renesas,rzg2l-canfd
    then:
      required:
        - resets
        - reset-names

Could a devicetree node missing the mandatory resets and reset-names
properties for RZ/G3L silently pass schema validation, allowing incomplete
hardware descriptions?

> +
> +      patternProperties:
> +        "^channel[3-7]$": false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015015336.816543-1-mkl@pengutronix.de?part=19