Re: [PATCH v9 1/2] can: j1939: fix possibility of list corruption in __j1939_ecu_release()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] can: j1939: missing Fixes trailer in commit message
--

commit 7c4d9fd75a33f174106e559336bfc8df216a8f66
Author: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>

> can: j1939: fix possibility of list corruption in __j1939_ecu_release()
>
> Since not all callers are calling j1939_ecu_put() with priv->lock held
> for write, list corruption might happen if the last user called
> j1939_ecu_put() without priv->lock held for write.
>
> Fix this problem by deferring release steps to WQ context where we can
> unconditionally hold priv->lock for write.
>
> By deferring to WQ context, readers might find ECUs which have already
> reached __j1939_ecu_release(). Therefore, allow using an ECU only when
> __j1939_ecu_release() is not yet called (indicated by ecu->kref > 0).
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>

[Severity: Low]
Since this fixes unlocked list removal in __j1939_ecu_release(), should
the commit message include a Fixes tag:

  Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/396b5de7-3fe0-474f-9194-b4816fde7182@I-love.SAKURA.ne.jp?part=1