From: sashiko-bot@kernel.org
To: raoxu <raoxu@uniontech.com>
Cc: linux-can@vger.kernel.org,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
"Oliver Hartkopp" <socketcan@hartkopp.net>,
"Vincent Mailhol" <mailhol@kernel.org>,
"Oleksij Rempel" <o.rempel@pengutronix.de>
Subject: Re: [PATCH] can: bcm: Account cyclic transmissions only on success
Date: Tue, 10 Nov 2026 05:29:09 +0000 [thread overview]
Message-ID: <sashiko-outbox-206293@kernel.org> (raw)
In-Reply-To: <45A9B6D8611C63C9+20261110052315.253367-1-raoxu@uniontech.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] can: bcm: missing Fixes: trailer for bcm_can_tx() bookkeeping
fix
--
commit ca441329b91ed7ef08326f38c9caaba62d3a18f6
Author: Xu Rao <raoxu@uniontech.com>
> can: bcm: Account cyclic transmissions only on success
>
> The CAN broadcast manager advances the cyclic frame index and decrements
> the initial-interval transmission count even when can_send() fails.
> For example, taking the CAN interface down makes can_send() return
> -ENETDOWN, but the timer still consumes the configured transmissions and
> can report TX_EXPIRED without sending a frame.
>
> Only update cyclic bookkeeping after can_send() succeeds. This matches
> the existing successful-send accounting of frames_abs while preserving
> the concurrent TX_RESET_MULTI_IDX check.
>
> Signed-off-by: Xu Rao <raoxu@uniontech.com>
[Severity: Low]
Since this fixes a bug in bcm_can_tx() cyclic transmission accounting,
should the commit message include a Fixes: trailer:
Fixes: ffd980f976e7 ("[CAN]: Add broadcast manager (bcm) protocol")
--
Sashiko AI review · https://sashiko.dev/#/patchset/45A9B6D8611C63C9+20261110052315.253367-1-raoxu@uniontech.com?part=1
next prev parent reply other threads:[~2026-11-10 5:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 5:23 [PATCH] can: bcm: Account cyclic transmissions only on success raoxu
2026-11-10 5:29 ` sashiko-bot [this message]
2026-11-10 8:38 ` Oliver Hartkopp
2026-11-11 21:54 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-206293@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=o.rempel@pengutronix.de \
--cc=raoxu@uniontech.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox