RE: ksmbd and reflink support - enables many more functional tests

Namjae Jeon
2021-05-21T02:27:30Z

I have been trying to reproduce this issue since yesterday. Hyunchul is also helping to reproduce it together.
We have not seen the issue ksmbd have crash yet.

And the test results were slightly different.

generic/110 12s ... 9s
generic/111 13s ... 10s
generic/115 13s ... 9s
generic/116 12s ... 10s
generic/118 12s ... 10s
generic/119 13s ... 10s
generic/134 12s ... 10s
generic/138 13s ... 10s
generic/139 13s ... 11s
generic/140 14s ... 10s
generic/142 14s ... 12s
generic/143 26s ... 23s
generic/144 13s ... 10s
generic/146 13s ... 11s
generic/148 13s ... 10s
generic/149 13s ... 10s
generic/150 13s ... 11s
generic/151 14s ... 10s
generic/152 14s ... 11s
generic/153 14s ... 11s
generic/154 14s ... 11s
generic/155 16s ... 13s
generic/161 59s ... 20s
generic/164 39s ... 38s
generic/165 47s ... 37s
generic/166 53s ... 51s
generic/167 49s ... 46s
generic/168 - output mismatch (see /home/linkinjeon/xfstests/loopback/xfstests-cifsd2/results//generic/168.out.bad)
--- tests/generic/168.out 2021-05-21 10:36:41.316652422 +0900
+++ /home/linkinjeon/xfstests/loopback/xfstests-cifsd2/results//generic/168.out.bad 2021-05-21 10:47:19.136657700 +0900
@@ -2,3 +2,26 @@
Format and mount
Initialize files
Reflink and write the target
+/mnt/read/test-168/file2: Bad file descriptor
+/mnt/read/test-168/file2: Bad file descriptor
+/mnt/read/test-168/file2: Bad file descriptor
+/mnt/read/test-168/file2: Bad file descriptor
...
(Run 'diff -u /home/linkinjeon/xfstests/loopback/xfstests-cifsd2/tests/generic/168.out /home/linkinjeon/xfstests/loopback/xfstests-cifsd2/results//generic/168.out.bad' to see the entire diff)
generic/170 - output mismatch (see /home/linkinjeon/xfstests/loopback/xfstests-cifsd2/results//generic/170.out.bad)
--- tests/generic/170.out 2021-05-21 10:36:47.132652470 +0900
+++ /home/linkinjeon/xfstests/loopback/xfstests-cifsd2/results//generic/170.out.bad 2021-05-21 10:49:36.696658838 +0900
@@ -2,3 +2,6 @@
Format and mount
Initialize files
Reflink and dio write the target
+/mnt/read/test-170/file2: Bad file descriptor
+/mnt/read/test-170/file2: Bad file descriptor
+/mnt/read/test-170/file2: Bad file descriptor
...
(Run 'diff -u /home/linkinjeon/xfstests/loopback/xfstests-cifsd2/tests/generic/170.out /home/linkinjeon/xfstests/loopback/xfstests-cifsd2/results//generic/170.out.bad' to see the entire diff)
generic/175 242s ... 294s
generic/176 1088s
generic/178 39s ... 38s
generic/179 35s ... 35s
generic/180 34s ... 32s
generic/181 37s ... 35s
generic/183 56s
generic/185 22s ... 17s
Ran: generic/110 generic/111 generic/115 generic/116 generic/118 generic/119 generic/134 generic/138 generic/139 generic/140 generic/142 generic/143 generic/144 generic/146 generic/148 generic/149 generic/150 generic/151 generic/152 generic/153 generic/154 generic/155 generic/161 generic/164 generic/165 generic/166 generic/167 generic/168 generic/170 generic/175 generic/176 generic/178 generic/179 generic/180 generic/181 generic/183 generic/185
Failures: generic/168 generic/170
Failed 2 of 37 tests

If there are error message from dmesg, It will helpful to find root-cause...

Thanks!
> -----Original Message-----
> From: Namjae Jeon <namjae.jeon@samsung.com>
> Sent: Thursday, May 20, 2021 10:44 AM
> To: 'Steve French' <smfrench@gmail.com>
> Cc: 'CIFS' <linux-cifs@vger.kernel.org>; 'COMMON INTERNET FILE SYSTEM SERVER' <linux-cifsd-
> devel@lists.sourceforge.net>
> Subject: RE: ksmbd and reflink support - enables many more functional tests
>
> Hi Steve,
> >
> > Did a run of reflink dependent xfstests against ksmbd (from current
> > 5.13-rc2 linux client) and see a very promising number (35+) of new tests that we should be able to
> enable. See below:
> Thanks for your check!
> >
> > generic/110 0s ... 0s
> > generic/111 0s ... 0s
> > generic/115 0s ... 0s
> > generic/116 0s ... 1s
> > generic/118 0s ... 0s
> > generic/119 1s ... 0s
> > generic/134 1s ... 1s
> > generic/138 0s ... 0s
> > generic/139 1s ... 1s
> > generic/140 0s ... 0s
> > generic/142 1s ... 2s
> > generic/143 2s ... 1s
> > generic/144 1s ... 1s
> > generic/146 1s ... 1s
> > generic/148 1s ... 0s
> > generic/149 0s ... 1s
> > generic/150 1s ... 0s
> > generic/151 0s ... 1s
> > generic/152 1s ... 1s
> > generic/153 0s ... 0s
> > generic/154 1s ... 1s
> > generic/155 0s ... 0s
> > generic/161 1s ... 1s
> > generic/164 8s ... 8s
> > generic/165 9s ... 8s
> > generic/166 6s ... 16s
> > generic/167 5s ... 230s
> > generic/168 46s ... 37s
> > generic/170 44s ... 103s
> > generic/175 7s
> > generic/176 58s ... 50s
> > generic/178 1s ... 0s
> > generic/179 0s ... 1s
> > generic/180 0s ... 0s
> >
> > After test 180 (for tests 181, 183, 185 and following eg.) I got
> > "could not connect to server" on all tests so ksmbd may have crashed
> > at that point
> Okay, I am trying to reproduce it.
>
> Thanks!
> > --
> > Thanks,
> >
> > Steve