From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: "'Jeremy Allison'" <jra@samba.org>,
"'Stefan Metzmacher'" <metze@samba.org>
Cc: "'Steve French'" <smfrench@gmail.com>,
"'CIFS'" <linux-cifs@vger.kernel.org>,
"'samba-technical'" <samba-technical@lists.samba.org>
Subject: RE: updated ksmbd (cifsd)
Date: Tue, 15 Dec 2020 11:29:01 +0900 [thread overview]
Message-ID: <003b01d6d28a$0caa3750$25fea5f0$@samsung.com> (raw)
In-Reply-To: <20201214184820.GB56567@jeremy-acer>
> On Mon, Dec 14, 2020 at 06:45:51PM +0100, Stefan Metzmacher via samba-technical wrote:
> >Am 14.12.20 um 02:20 schrieb Steve French via samba-technical:
> >> I just rebased https://protect2.fireeye.com/v1/url?k=e100f21c-be9bcb17-e1017953-002590f5b904-
> f00629b46b3afee4&q=1&e=6fc8b980-0fd2-4e4d-a9dc-
> 9ea15e482833&u=https%3A%2F%2Fgithub.com%2Fsmfrench%2Fsmb3-kernel%2Ftree%2Fcifsd-for-next
> >> ontop of 5.10 kernel. Let me know if you see any problems. xfstest
> >> results (and recent improvements) running Linux cifs.ko->ksmbd look
> >> very promising.
> >
> >I just looked briefly, but I'm wondering about a few things:
> >
> >1. The xattr's to store additional meta data are not compatible with
> > Samba's way of storing things:
> >
> >https://protect2.fireeye.com/v1/url?k=fbb13e03-a42a0708-fbb0b54c-002590
> >f5b904-f4288e37b0eb9ae8&q=1&e=6fc8b980-0fd2-4e4d-a9dc-9ea15e482833&u=ht
> >tps%3A%2F%2Fgit.samba.org%2F%3Fp%3Dsamba.git%3Ba%3Dblob%3Bf%3Dlibrpc%2F
> >idl%2Fxattr.idl
> >
> > In order to make it possible to use the same filesystem with both servers
> > it would be great if the well established way used in Samba would be used
> > as well.
>
> A thousand times this ! If cifs.ko->ksmbd adds a differnt way of storing the extra meta-data that is
> incompatible with Samba this would be a disaster for users.
>
> Please fix this before proposing any merge.
You said that samba can handle it even if ksmbd has own extra metadata format. I didn't think it was
necessary to what you said. If we have to do this, I think it is not too late to work after sending
ksmbd to linux-next first.
next prev parent reply other threads:[~2020-12-15 2:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 1:20 updated ksmbd (cifsd) Steve French
2020-12-14 12:46 ` Namjae Jeon
2020-12-15 2:28 ` Namjae Jeon
2020-12-14 17:45 ` Stefan Metzmacher
2020-12-14 18:48 ` Jeremy Allison
2020-12-15 2:29 ` Namjae Jeon [this message]
2020-12-15 4:13 ` Jeremy Allison
2020-12-15 2:28 ` Namjae Jeon
2020-12-15 14:29 ` Stefan Metzmacher
2020-12-16 3:24 ` Sergey Senozhatsky
2020-12-16 4:21 ` Sergey Senozhatsky
2020-12-17 3:29 ` Sergey Senozhatsky
2020-12-16 8:50 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003b01d6d28a$0caa3750$25fea5f0$@samsung.com' \
--to=namjae.jeon@samsung.com \
--cc=jra@samba.org \
--cc=linux-cifs@vger.kernel.org \
--cc=metze@samba.org \
--cc=samba-technical@lists.samba.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox