Re: [PATCH v21 00/22] Richacls

Re: [PATCH v21 00/22] Richacls

[James Johnston]

> On Tue, May 10, 2016 at 06:18:10AM +0200, Volker Lendecke wrote:
> > On Tue, May 10, 2016 at 12:02:33AM +0200, Andreas Gruenbacher wrote:
> > > What more can I do to finally get this merged?
> > 
> > While I am not the one to comment on kernel specifics, from a pure Samba
> > user space perspective let me say: We need this. NOW.
>
> +1 from me. This is something that many vendors need
> and have needed for a very long time. Getting this
> in will allow *large* amounts of existing storage to
> be migrated to Linux.

As a "mere" end-user of SAMBA, +1 from me also...  It's my understanding
that this patch set would help eliminate the need for hacks like
vfs_acl_xattr that store ACLs in extended attributes that only SAMBA
understands.  If the file system itself can respect the ACLs that seems
like a lot cleaner solution.

James

[PATCH v21 00/22] Richacls

[Andreas Gruenbacher]

Al,

here is an update to the richacl patches.  Changes since the last posting
(https://lwn.net/Articles/680388/):

 * Rebase on top of work.acl [*].  Minor restructuring of the functions
   accessing the cached ACLs in inodes.

[*] https://git.kernel.org/cgit/linux/kernel/git/viro/vfs.git/log/?h=work.acl


The complete patch queue is available here:

  git://git.kernel.org/pub/scm/linux/kernel/git/agruen/linux-richacl.git \
        richacl-2016-05-10


The richacl user-space utilitites, man pages, and test suite are available
here:

  https://github.com/andreas-gruenbacher/richacl


Changes to other user-space packages for richacl:

  https://github.com/andreas-gruenbacher/coreutils
  https://github.com/andreas-gruenbacher/e2fsprogs
  https://github.com/andreas-gruenbacher/samba
  https://github.com/andreas-gruenbacher/xfsprogs-dev
  https://github.com/andreas-gruenbacher/nfs-utils


Please see the richacl homepage for more information:

  http://www.bestbits.at/richacl/


What more can I do to finally get this merged?

Thanks,
Andreas


Andreas Gruenbacher (20):
  vfs: Add IS_ACL() and IS_RICHACL() tests
  vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags
  vfs: Add MAY_DELETE_SELF and MAY_DELETE_CHILD permission flags
  vfs: Make the inode passed to inode_change_ok non-const
  vfs: Add permission flags for setting file attributes
  richacl: In-memory representation and helper functions
  richacl: Permission mapping functions
  richacl: Compute maximum file masks from an acl
  richacl: Permission check algorithm
  posix_acl: Improve xattr fixup code
  vfs: Cache base_acl objects in inodes
  vfs: Add get_richacl and set_richacl inode operations
  vfs: Cache richacl in struct inode
  richacl: Update the file masks in chmod()
  richacl: Check if an acl is equivalent to a file mode
  richacl: Create-time inheritance
  richacl: Automatic Inheritance
  richacl: xattr mapping functions
  richacl: Add richacl xattr handler
  vfs: Add richacl permission checking

Aneesh Kumar K.V (2):
  ext4: Add richacl support
  ext4: Add richacl feature flag

 drivers/staging/lustre/lustre/llite/llite_lib.c |   2 +-
 fs/9p/acl.c                                     |   8 +-
 fs/Kconfig                                      |   3 +
 fs/Makefile                                     |   1 +
 fs/attr.c                                       |  81 ++-
 fs/ext4/Kconfig                                 |  11 +
 fs/ext4/Makefile                                |   1 +
 fs/ext4/ext4.h                                  |   6 +-
 fs/ext4/file.c                                  |   3 +
 fs/ext4/ialloc.c                                |  11 +-
 fs/ext4/inode.c                                 |   5 +-
 fs/ext4/namei.c                                 |   5 +
 fs/ext4/richacl.c                               | 134 ++++
 fs/ext4/richacl.h                               |  40 ++
 fs/ext4/super.c                                 |  49 +-
 fs/ext4/xattr.c                                 |   7 +
 fs/f2fs/acl.c                                   |   4 +-
 fs/inode.c                                      |  43 +-
 fs/jffs2/acl.c                                  |   6 +-
 fs/namei.c                                      | 154 ++--
 fs/nfs/nfs3acl.c                                |  14 +-
 fs/posix_acl.c                                  |  69 +-
 fs/richacl.c                                    | 893 ++++++++++++++++++++++++
 fs/richacl_xattr.c                              | 235 +++++++
 fs/xattr.c                                      |  29 +-
 include/linux/acl.h                             |  15 +
 include/linux/fs.h                              |  67 +-
 include/linux/posix_acl.h                       |  21 +-
 include/linux/richacl.h                         | 210 ++++++
 include/linux/richacl_xattr.h                   |  31 +
 include/uapi/linux/Kbuild                       |   2 +
 include/uapi/linux/fs.h                         |   3 +-
 include/uapi/linux/richacl.h                    | 152 ++++
 include/uapi/linux/richacl_xattr.h              |  44 ++
 include/uapi/linux/xattr.h                      |   2 +
 35 files changed, 2200 insertions(+), 161 deletions(-)
 create mode 100644 fs/ext4/richacl.c
 create mode 100644 fs/ext4/richacl.h
 create mode 100644 fs/richacl.c
 create mode 100644 fs/richacl_xattr.c
 create mode 100644 include/linux/acl.h
 create mode 100644 include/linux/richacl.h
 create mode 100644 include/linux/richacl_xattr.h
 create mode 100644 include/uapi/linux/richacl.h
 create mode 100644 include/uapi/linux/richacl_xattr.h

-- 
2.5.5

Re: [PATCH v21 00/22] Richacls

[Volker Lendecke]

On Tue, May 10, 2016 at 12:02:33AM +0200, Andreas Gruenbacher wrote:
> What more can I do to finally get this merged?

While I am not the one to comment on kernel specifics, from a pure Samba
user space perspective let me say: We need this. NOW.

Volker

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH v21 00/22] Richacls

[Jeremy Allison]

On Tue, May 10, 2016 at 06:18:10AM +0200, Volker Lendecke wrote:
> On Tue, May 10, 2016 at 12:02:33AM +0200, Andreas Gruenbacher wrote:
> > What more can I do to finally get this merged?
> 
> While I am not the one to comment on kernel specifics, from a pure Samba
> user space perspective let me say: We need this. NOW.

+1 from me. This is something that many vendors need
and have needed for a very long time. Getting this
in will allow *large* amounts of existing storage to
be migrated to Linux.

Re: [PATCH v21 00/22] Richacls

[Volker Lendecke]

On Tue, May 10, 2016 at 10:11:50AM +0200, Jeremy Allison wrote:
> +1 from me. This is something that many vendors need
> and have needed for a very long time. Getting this
> in will allow *large* amounts of existing storage to
> be migrated to Linux.

ZFS has NFSv4 richacls, and people seem to risk shitstorms
for ZFS. Not only for this of course, but they do
contribute.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt@sernet.de
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH v21 00/22] Richacls

[Frank Filz]

> On Tue, May 10, 2016 at 06:18:10AM +0200, Volker Lendecke wrote:
> > On Tue, May 10, 2016 at 12:02:33AM +0200, Andreas Gruenbacher wrote:
> > > What more can I do to finally get this merged?
> >
> > While I am not the one to comment on kernel specifics, from a pure
> > Samba user space perspective let me say: We need this. NOW.
> 
> +1 from me. This is something that many vendors need
> and have needed for a very long time. Getting this in will allow *large*
> amounts of existing storage to be migrated to Linux.

+1 from me also. Once this is in Ganesha will integrate with it also.

Frank


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs