From: ZhangGuoDong <zhang.guodong@linux.dev>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: smfrench@gmail.com, chenxiaosong@kylinos.cn,
chenxiaosong@chenxiaosong.com, linux-cifs@vger.kernel.org
Subject: Re: [PATCH v5 7/7] smb: introduce struct file_posix_info
Date: Tue, 10 Mar 2026 09:17:04 +0800 [thread overview]
Message-ID: <0858a9d3-f26d-4bb3-98cb-3e73abfa1399@linux.dev> (raw)
In-Reply-To: <CAKYAXd-_OU+YMpUmUKR0m86L+OqHPoa1T1WSDgAfo7H70tv_Sw@mail.gmail.com>
Hi Namjae,
The client cannot use `SidBuffer[32]` because the size of `SidBuffer[]`
on the client side is not necessarily 32.
在 2026/3/10 09:02, Namjae Jeon 写道:
>> /* SidBuffer contain two sids (UNIX user sid(16), UNIX group sid(16)) */
>> u8 SidBuffer[32];
>> __le32 name_len;
>> u8 name[];
> These 3 fields should be removed and use flex array in struct file_posix_info.
> And why can't smb2_posix_info move to /smb/common?
next prev parent reply other threads:[~2026-03-10 1:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 15:13 [PATCH v5 0/7] smb: fix some bugs, move duplicate definitions into common header file, part 2 zhang.guodong
2026-03-03 15:13 ` [PATCH v5 1/7] smb/client: fix buffer size for smb311_posix_qinfo in smb2_compound_op() zhang.guodong
2026-03-03 23:58 ` Steve French
2026-03-04 0:07 ` ZhangGuoDong
2026-03-04 0:06 ` Steve French
2026-03-03 15:13 ` [PATCH v5 2/7] smb/client: fix buffer size for smb311_posix_qinfo in SMB311_posix_query_info() zhang.guodong
2026-03-04 0:05 ` Steve French
2026-03-03 15:13 ` [PATCH v5 3/7] smb/client: remove unused SMB311_posix_query_info() zhang.guodong
2026-03-04 0:05 ` Steve French
2026-03-03 15:13 ` [PATCH v5 4/7] smb: move some definitions from common/smb2pdu.h into common/fscc.h zhang.guodong
2026-03-03 15:13 ` [PATCH v5 5/7] smb: move file_basic_info " zhang.guodong
2026-03-03 15:13 ` [PATCH v5 6/7] smb: move filesystem_vol_info " zhang.guodong
2026-03-03 15:13 ` [PATCH v5 7/7] smb: introduce struct file_posix_info zhang.guodong
2026-03-10 1:02 ` Namjae Jeon
2026-03-10 1:17 ` ZhangGuoDong [this message]
2026-03-10 1:25 ` Namjae Jeon
2026-03-10 1:31 ` ZhangGuoDong
2026-03-10 0:57 ` [PATCH v5 0/7] smb: fix some bugs, move duplicate definitions into common header file, part 2 Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0858a9d3-f26d-4bb3-98cb-3e73abfa1399@linux.dev \
--to=zhang.guodong@linux.dev \
--cc=chenxiaosong@chenxiaosong.com \
--cc=chenxiaosong@kylinos.cn \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox