Re: [PATCH] filelock: move file locking definitions to separate header file

Matthew Wilcox
2022-11-22T03:52:21Z

On Sun, Nov 20, 2022 at 03:59:57PM -0500, Jeff Layton wrote:
> Move the file locking definitions to a new header file, and add the
> appropriate #include directives to the source files that need them. By
> doing this we trim down fs.h a bit and limit the amount of rebuilding
> that has to be done when we make changes to the file locking APIs.

I'm in favour of this in general, but I think there's a few implicit
includes. Can you create a test.c that only #include
<linnux/filelock.h> and see if there's anything missing?

> + wait_queue_head_t fl_wait;
> + struct file *fl_file;

These two seem undefined at this point.

> + struct fasync_struct * fl_fasync; /* for lease break notifications */

Likewise.