From: Jens Axboe <axboe@kernel.dk>
To: David Howells <dhowells@redhat.com>
Cc: Steve French <stfrench@microsoft.com>,
Jeff Layton <jlayton@kernel.org>,
Enzo Matsumiya <ematsumiya@suse.de>,
Matthew Wilcox <willy@infradead.org>,
Christian Brauner <brauner@kernel.org>,
netfs@lists.linux.dev, v9fs@lists.linux.dev,
linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netfs: Fix setting of BDP_ASYNC from iocb flags
Date: Tue, 21 May 2024 10:04:59 -0600 [thread overview]
Message-ID: <110d2995-f473-4781-9412-30f7f96858dd@kernel.dk> (raw)
In-Reply-To: <316428.1716306899@warthog.procyon.org.uk>
On 5/21/24 9:54 AM, David Howells wrote:
> Jens Axboe <axboe@kernel.dk> wrote:
>
>> However, I'll note that BDP_ASYNC is horribly named, it should be
>> BDP_NOWAIT instead. But that's a separate thing, fix looks correct
>> as-is.
>
> I thought IOCB_NOWAIT was related to RWF_NOWAIT, but apparently not from the
> code.
It is, something submitted with RWF_NOWAIT should have IOCB_NOWAIT set.
But RWF_NOWAIT isn't the sole user of IOCB_NOWAIT, and no assumptions
should be made about whether something is sync or async based on whether
or not RWF_NOWAIT is set. Those aren't related other than _some_ proper
async IO will have IOCB_NOWAIT set, and others will not.
--
Jens Axboe
next prev parent reply other threads:[~2024-05-21 16:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 15:49 [PATCH] netfs: Fix setting of BDP_ASYNC from iocb flags David Howells
2024-05-21 15:52 ` Jens Axboe
2024-05-21 15:54 ` David Howells
2024-05-21 16:04 ` Jens Axboe [this message]
2024-05-21 20:05 ` David Howells
2024-05-21 20:09 ` Jens Axboe
2024-05-22 7:14 ` Christian Brauner
2024-05-24 15:33 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=110d2995-f473-4781-9412-30f7f96858dd@kernel.dk \
--to=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=ematsumiya@suse.de \
--cc=jlayton@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfs@lists.linux.dev \
--cc=stfrench@microsoft.com \
--cc=v9fs@lists.linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox