From: David Howells <dhowells@redhat.com>
To: Rohith Surabattula <rohiths.msft@gmail.com>
Cc: dhowells@redhat.com, Steve French <smfrench@gmail.com>,
Shyam Prasad N <nspmangalore@gmail.com>,
ronnie sahlberg <ronniesahlberg@gmail.com>,
Paulo Alcantara <pc@cjr.nz>, Jeff Layton <jlayton@kernel.org>,
CIFS <linux-cifs@vger.kernel.org>,
natomar@microsoft.com
Subject: Re: cifs conversion to netfslib
Date: Mon, 21 Mar 2022 17:18:30 +0000 [thread overview]
Message-ID: <1147495.1647883110@warthog.procyon.org.uk> (raw)
In-Reply-To: <CACdtm0acOifDsToq3-ocxV2pfXkBX2CoJ64_B_vxMu6mJvN7bA@mail.gmail.com>
Rohith Surabattula <rohiths.msft@gmail.com> wrote:
> Snippet from cifs_writev:
> rc = extract_iter_to_iter(from, ctx->len, &ctx->iter, &ctx->bv);
> if (rc < 0) {
> kref_put(&ctx->refcount, cifs_aio_ctx_release);
> return rc;
> }
> ctx->npages = rc;
> ctx->len = iov_iter_count(&ctx->iter);
Bah. ctx->len is 0 at the point of the extraction. That should be:
rc = extract_iter_to_iter(from, iov_iter_count(from), &ctx->iter, &ctx->bv);
David
prev parent reply other threads:[~2022-03-21 17:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 8:19 cifs conversion to netfslib David Howells
2022-03-11 8:25 ` David Howells
2022-03-15 3:50 ` Rohith Surabattula
2022-03-15 9:54 ` Rohith Surabattula
2022-03-17 0:07 ` David Howells
2022-03-17 16:16 ` David Howells
2022-03-18 0:21 ` David Howells
2022-03-18 2:52 ` Steve French
2022-03-21 10:19 ` Rohith Surabattula
2022-03-21 17:18 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1147495.1647883110@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=natomar@microsoft.com \
--cc=nspmangalore@gmail.com \
--cc=pc@cjr.nz \
--cc=rohiths.msft@gmail.com \
--cc=ronniesahlberg@gmail.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox