From: David Howells <dhowells@redhat.com>
To: Enzo Matsumiya <ematsumiya@suse.de>
Cc: dhowells@redhat.com, Steve French <sfrench@samba.org>,
Paulo Alcantara <pc@manguebit.org>,
linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cifs: Fix TCP_Server_Info::credits to be signed
Date: Mon, 20 Oct 2025 15:08:26 +0100 [thread overview]
Message-ID: <1158747.1760969306@warthog.procyon.org.uk> (raw)
In-Reply-To: <vmbhu5djhw2fovzwpa6dptuthwocmjc5oh6vsi4aolodstmqix@4jv64tzfe3qp>
Enzo Matsumiya <ematsumiya@suse.de> wrote:
> Both semantically and technically, credits shouldn't go negative.
> Shouldn't those other fields/functions become unsigned instead?
That's really a question for Steve, but it makes it easier to handle
underflow, and I'm guessing that the maximum credits isn't likely to exceed
2G.
David
next prev parent reply other threads:[~2025-10-20 14:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 8:46 [PATCH] cifs: Fix TCP_Server_Info::credits to be signed David Howells
2025-10-20 13:32 ` Enzo Matsumiya
2025-10-20 14:08 ` David Howells [this message]
2025-10-20 14:45 ` Enzo Matsumiya
2025-10-20 16:58 ` Steve French
2025-10-24 11:56 ` Shyam Prasad N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1158747.1760969306@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=ematsumiya@suse.de \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pc@manguebit.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox