From: Andrew Bartlett <abartlet@samba.org>
To: Steve French <smfrench@gmail.com>
Cc: linux-cifs@vger.kernel.org, jason@jacknife2.dns2go.com,
samba-technical <samba-technical@lists.samba.org>,
Jeff Layton <jlayton@redhat.com>,
elliot.li.tech@gmail.com
Subject: Re: [PATCH] cifs: ignore everything in SPNEGO blob after mechTypes
Date: Mon, 18 Mar 2013 08:14:14 +1100 [thread overview]
Message-ID: <1363554854.27367.8.camel@jesse> (raw)
In-Reply-To: <CAH2r5mtcACcO5YfVzRptJO2ob=SYEgVyTtHBUc7XZS_n57XjAw@mail.gmail.com>
On Sun, 2013-03-17 at 09:37 -0500, Steve French wrote:
> The existing code is trying to dump the "principal" from the
> mechListMic (presumably for debugging) in the SMB negotiate response.
> In the trace I looked at Samba server set it to "NONE" - is there a
> case where we would ever need that?
No, the "principal" should never be used, and isn't even useful for
debugging as you should just never use it. It can be set to strange and
invalid values such as NONE and rfc....should_ignore
Andrew Bartlett
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
next prev parent reply other threads:[~2013-03-17 21:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 13:52 [PATCH] cifs: ignore everything in SPNEGO blob after mechTypes Jeff Layton
[not found] ` <1363009939-2264-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-03-12 18:27 ` Yan Li
[not found] ` <D964BE89-1509-4A58-B079-37F17449F4F5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-03-14 11:41 ` Jeff Layton
2013-03-17 14:37 ` Steve French
2013-03-17 21:14 ` Andrew Bartlett [this message]
2013-03-17 22:00 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363554854.27367.8.camel@jesse \
--to=abartlet@samba.org \
--cc=elliot.li.tech@gmail.com \
--cc=jason@jacknife2.dns2go.com \
--cc=jlayton@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox