linux-cifs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sachin Prabhu <sprabhu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>,
	Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
	Steve French
	<steve.french-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
Subject: Re: [PATCH] CIFS: Remove some obsolete comments
Date: Thu, 19 May 2016 19:31:49 +0100	[thread overview]
Message-ID: <1463682709.3144.1.camel@redhat.com> (raw)
In-Reply-To: <1463623053-117056-1-git-send-email-smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Wed, 2016-05-18 at 20:57 -0500, Steve French wrote:
> Remove some obsolete comments in the cifs inode_operations
> structs that were pointed out by Stephen Rothwell.
> 
> CC: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
> CC: Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
> Signed-off-by: Steve French <steve.french-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>

Acked-By: Sachin Prabhu <sprabhu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

> ---
>  fs/cifs/cifsfs.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
> index 67f622d..5d8b7ed 100644
> --- a/fs/cifs/cifsfs.c
> +++ b/fs/cifs/cifsfs.c
> @@ -890,7 +890,6 @@ const struct inode_operations cifs_dir_inode_ops
> = {
>  	.rmdir = cifs_rmdir,
>  	.rename2 = cifs_rename2,
>  	.permission = cifs_permission,
> -/*	revalidate:cifs_revalidate,   */
>  	.setattr = cifs_setattr,
>  	.symlink = cifs_symlink,
>  	.mknod   = cifs_mknod,
> @@ -901,9 +900,8 @@ const struct inode_operations cifs_dir_inode_ops
> = {
>  };
>  
>  const struct inode_operations cifs_file_inode_ops = {
> -/*	revalidate:cifs_revalidate, */
>  	.setattr = cifs_setattr,
> -	.getattr = cifs_getattr, /* do we need this anymore? */
> +	.getattr = cifs_getattr,
>  	.permission = cifs_permission,
>  	.setxattr = generic_setxattr,
>  	.getxattr = generic_getxattr,
> @@ -915,9 +913,6 @@ const struct inode_operations
> cifs_symlink_inode_ops = {
>  	.readlink = generic_readlink,
>  	.get_link = cifs_get_link,
>  	.permission = cifs_permission,
> -	/* BB add the following two eventually */
> -	/* revalidate: cifs_revalidate,
> -	   setattr:    cifs_notify_change, *//* BB do we need notify
> change */
>  	.setxattr = generic_setxattr,
>  	.getxattr = generic_getxattr,
>  	.listxattr = cifs_listxattr,

      parent reply	other threads:[~2016-05-19 18:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-19  1:57 [PATCH] CIFS: Remove some obsolete comments Steve French
     [not found] ` <1463623053-117056-1-git-send-email-smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-05-19 18:31   ` Sachin Prabhu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463682709.3144.1.camel@redhat.com \
    --to=sprabhu-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org \
    --cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=steve.french-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org \
    --cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).