From: Jeff Layton <jlayton-vpEMnDpepFuMZCB2o+C8xQ@public.gmane.org>
To: Thomas Witt <pyromaniac-k5O9xmZG+kVAfugRpC6u6w@public.gmane.org>,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] mount.cifs: Remove data_blob.h include
Date: Thu, 16 Mar 2017 06:40:15 -0400 [thread overview]
Message-ID: <1489660814.2650.1.camel@poochiereds.net> (raw)
In-Reply-To: <20170315202044.28670-1-pyromaniac-k5O9xmZG+kVAfugRpC6u6w@public.gmane.org>
On Wed, 2017-03-15 at 20:20 +0000, Thomas Witt wrote:
> data_blob.h includes talloc.h from libtalloc, but that is only marked as
> a dependency for cifs.upcall. No symbols from that header are used by
> cifs.mount, so remove it to avoid the libtalloc dependency
>
> Signed-off-by: Thomas Witt <pyromaniac-k5O9xmZG+kVAfugRpC6u6w@public.gmane.org>
> ---
> mount.cifs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mount.cifs.c b/mount.cifs.c
> index 13b71ef..2612feb 100644
> --- a/mount.cifs.c
> +++ b/mount.cifs.c
> @@ -61,7 +61,6 @@
> #include "mount.h"
> #include "util.h"
> #include "resolve_host.h"
> -#include "data_blob.h"
>
> #ifndef MS_MOVE
> #define MS_MOVE 8192
Thanks! Yes, that was leftover from my first pass on cleaning up some of
the replace.h code.
Patch merged and should make 6.8.
--
Jeff Layton <jlayton-vpEMnDpepFuMZCB2o+C8xQ@public.gmane.org>
prev parent reply other threads:[~2017-03-16 10:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 20:20 [PATCH] mount.cifs: Remove data_blob.h include Thomas Witt
[not found] ` <20170315202044.28670-1-pyromaniac-k5O9xmZG+kVAfugRpC6u6w@public.gmane.org>
2017-03-16 10:40 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489660814.2650.1.camel@poochiereds.net \
--to=jlayton-vpemndpepfumzcb2o+c8xq@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pyromaniac-k5O9xmZG+kVAfugRpC6u6w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).