* [PATCH] mount.cifs: Remove data_blob.h include
@ 2017-03-15 20:20 Thomas Witt
[not found] ` <20170315202044.28670-1-pyromaniac-k5O9xmZG+kVAfugRpC6u6w@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Witt @ 2017-03-15 20:20 UTC (permalink / raw)
To: linux-cifs-u79uwXL29TY76Z2rM5mHXA
data_blob.h includes talloc.h from libtalloc, but that is only marked as
a dependency for cifs.upcall. No symbols from that header are used by
cifs.mount, so remove it to avoid the libtalloc dependency
Signed-off-by: Thomas Witt <pyromaniac-k5O9xmZG+kVAfugRpC6u6w@public.gmane.org>
---
mount.cifs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mount.cifs.c b/mount.cifs.c
index 13b71ef..2612feb 100644
--- a/mount.cifs.c
+++ b/mount.cifs.c
@@ -61,7 +61,6 @@
#include "mount.h"
#include "util.h"
#include "resolve_host.h"
-#include "data_blob.h"
#ifndef MS_MOVE
#define MS_MOVE 8192
--
2.12.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mount.cifs: Remove data_blob.h include
[not found] ` <20170315202044.28670-1-pyromaniac-k5O9xmZG+kVAfugRpC6u6w@public.gmane.org>
@ 2017-03-16 10:40 ` Jeff Layton
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Layton @ 2017-03-16 10:40 UTC (permalink / raw)
To: Thomas Witt, linux-cifs-u79uwXL29TY76Z2rM5mHXA
On Wed, 2017-03-15 at 20:20 +0000, Thomas Witt wrote:
> data_blob.h includes talloc.h from libtalloc, but that is only marked as
> a dependency for cifs.upcall. No symbols from that header are used by
> cifs.mount, so remove it to avoid the libtalloc dependency
>
> Signed-off-by: Thomas Witt <pyromaniac-k5O9xmZG+kVAfugRpC6u6w@public.gmane.org>
> ---
> mount.cifs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mount.cifs.c b/mount.cifs.c
> index 13b71ef..2612feb 100644
> --- a/mount.cifs.c
> +++ b/mount.cifs.c
> @@ -61,7 +61,6 @@
> #include "mount.h"
> #include "util.h"
> #include "resolve_host.h"
> -#include "data_blob.h"
>
> #ifndef MS_MOVE
> #define MS_MOVE 8192
Thanks! Yes, that was leftover from my first pass on cleaning up some of
the replace.h code.
Patch merged and should make 6.8.
--
Jeff Layton <jlayton-vpEMnDpepFuMZCB2o+C8xQ@public.gmane.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-16 10:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-15 20:20 [PATCH] mount.cifs: Remove data_blob.h include Thomas Witt
[not found] ` <20170315202044.28670-1-pyromaniac-k5O9xmZG+kVAfugRpC6u6w@public.gmane.org>
2017-03-16 10:40 ` Jeff Layton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).