Re: [PATCH 1/4] netfs: when subreq is marked for retry, do not check if it faced an error

[David Howells <dhowells@redhat.com>]

nspmangalore@gmail.com wrote:

> @@ -547,13 +547,15 @@ void netfs_read_subreq_terminated(struct netfs_io_subrequest *subreq)
>  	}
>  
>  	if (unlikely(subreq->error < 0)) {
> -		trace_netfs_failure(rreq, subreq, subreq->error, netfs_fail_read);
>  		if (subreq->source == NETFS_READ_FROM_CACHE) {
>  			netfs_stat(&netfs_n_rh_read_failed);
>  			__set_bit(NETFS_SREQ_NEED_RETRY, &subreq->flags);
>  		} else {
>  			netfs_stat(&netfs_n_rh_download_failed);
> -			__set_bit(NETFS_SREQ_FAILED, &subreq->flags);
> +			if (!test_bit(NETFS_SREQ_NEED_RETRY, &subreq->flags)) {
> +				__set_bit(NETFS_SREQ_FAILED, &subreq->flags);
> +				trace_netfs_failure(rreq, subreq, subreq->error, netfs_fail_read);
> +			}
>  		}
>  		trace_netfs_rreq(rreq, netfs_rreq_trace_set_pause);
>  		set_bit(NETFS_RREQ_PAUSE, &rreq->flags);

I think I suggested moving the check for NETFS_SREQ_NEED_RETRY up in the
function - above any checks of subreq->error, but after the initial stat
counting.

Ditto for netfs_write_subrequest_terminated().  Actually, the
transferred_or_error argument of that should be got rid of and the filesystem
update the subreq->error and subreq->transferred fields directly as for reads.

I can poke at this tomorrow if you want.

David