From: Paulo Alcantara <pc@manguebit.com>
To: Ronnie Sahlberg <lsahlber@redhat.com>,
linux-cifs <linux-cifs@vger.kernel.org>
Cc: Steve French <smfrench@gmail.com>
Subject: Re: [PATCH 1/2] cifs: Check the lease context if we actually got a lease
Date: Fri, 17 Feb 2023 10:37:51 -0300 [thread overview]
Message-ID: <16d7d475fd223ebe40d685951665b7cb@manguebit.com> (raw)
In-Reply-To: <20230217033501.2591185-1-lsahlber@redhat.com>
Ronnie Sahlberg <lsahlber@redhat.com> writes:
> Some servers may return that we got a lease in rsp->OplockLevel
> but then in the lease context contradict this and say we got no lease
> at all. Thus we need to check the context if we have a lease.
> Additionally, IF we do not get a lease we need to make sure we close
> the handle before we return an error to the caller.
>
> Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
> ---
> fs/cifs/cached_dir.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
Reviewed-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
prev parent reply other threads:[~2023-02-17 13:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 3:35 [PATCH 1/2] cifs: Check the lease context if we actually got a lease Ronnie Sahlberg
2023-02-17 3:35 ` [PATCH 2/2] cifs: return a single-use cfid if we did not get " Ronnie Sahlberg
2023-02-17 5:40 ` Steve French
2023-02-17 5:47 ` ronnie sahlberg
2023-02-17 13:38 ` Paulo Alcantara
2023-02-17 13:37 ` Paulo Alcantara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16d7d475fd223ebe40d685951665b7cb@manguebit.com \
--to=pc@manguebit.com \
--cc=linux-cifs@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox