From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Neuling Subject: Re: [Stable-review] [26/34] CIFS: Fix compile error with __init in cifs_init_dns_resolver() definition Date: Sat, 07 Aug 2010 13:38:53 +1000 Message-ID: <17422.1281152333@neuling.org> References: <20100806185836.185076461@clark.site> <1281127997.7543.0.camel@localhost> <20100806210619.GA5863@suse.de> Cc: Ben Hutchings , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, stable-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, David Howells , linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jeff Layton , akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, stable-review-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org To: Greg KH Return-path: In-reply-to: <20100806210619.GA5863-l3A5Bk7waGM@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: In message <20100806210619.GA5863-l3A5Bk7waGM@public.gmane.org> you wrote: > On Fri, Aug 06, 2010 at 09:53:17PM +0100, Ben Hutchings wrote: > > On Fri, 2010-08-06 at 11:57 -0700, Greg KH wrote: > > > 2.6.32-stable review patch. If anyone has any objections, please let us know. > > > > > > ------------------ > > > [stable] [PATCH 2.6.32/stable] CIFS: Fix compile error with __init in ci fs_init_dns_resolver() definition > > > > > > From: Michael Neuling > > > > > > An allmodconfig compile on ppc64 with 2.6.32.17 currently gives this erro r > > > > > > fs/cifs/dns_resolve.h:27: error: expected '=', ',', ';', 'asm' or '__attr ibute__' before 'cifs_init_dns_resolver' > > > > > > This adds the correct header file to fix this. > > [...] > > > > Why and not ? > > Heh, it works :) > > Michael? It's what David Howells wanted..... http://linux.derkeiler.com/Mailing-Lists/Kernel/2010-08/msg01316.html (below as well) > An allmodconfig compile on ppc64 with 2.6.32.17 currently gives this error > > fs/cifs/dns_resolve.h:27: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'cifs_init_dns_resolver' > > This removes the __init from cifs_init_dns_resolver() That's not really a good idea as the assembler may choose different pieces of assembly to do variable references and jumps, depending on the section information. A better fix is to add: #include to the header file. David