From: Ralph Boehme <slow@samba.org>
To: Hobin Woo <hobin.woo@samsung.com>, linux-cifs@vger.kernel.org
Cc: linkinjeon@kernel.org, sfrench@samba.org,
senozhatsky@chromium.org, tom@talpey.com, sj1557.seo@samsung.com,
yoonho.shin@samsung.com, kiras.lee@samsung.com
Subject: Re: [PATCH v2] ksmb: discard write access to the directory open
Date: Fri, 5 Jul 2024 13:53:43 +0200 [thread overview]
Message-ID: <1995c5b6-0f3f-422b-85e4-8ebd38916a08@samba.org> (raw)
In-Reply-To: <20240705032725.39761-1-hobin.woo@samsung.com>
[-- Attachment #1.1: Type: text/plain, Size: 533 bytes --]
On 7/5/24 5:27 AM, Hobin Woo wrote:
> may_open() does not allow a directory to be opened with the write access.
> However, some writing flags set by client result in adding write access
> on server, making ksmbd incompatible with FUSE file system. Simply, let's
> discard the write access when opening a directory.
afair this should cause a failure like EACCESS or EISDIR and just be
ignored. What does a Windows server return in this case, or Samba for
that matter as it (hopefully) will behave like Windows.
-slow
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2024-07-05 12:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240705032731epcas1p177d910a154ded37c459af1c2374a3571@epcas1p1.samsung.com>
2024-07-05 3:27 ` [PATCH v2] ksmb: discard write access to the directory open Hobin Woo
2024-07-05 11:39 ` Namjae Jeon
2024-07-05 14:57 ` Steve French
2024-07-05 11:53 ` Ralph Boehme [this message]
2024-07-05 12:33 ` Namjae Jeon
2024-07-05 13:16 ` Ralph Boehme
2024-07-05 13:51 ` Tom Talpey
2024-07-08 12:31 ` Hobin Woo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1995c5b6-0f3f-422b-85e4-8ebd38916a08@samba.org \
--to=slow@samba.org \
--cc=hobin.woo@samsung.com \
--cc=kiras.lee@samsung.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=sfrench@samba.org \
--cc=sj1557.seo@samsung.com \
--cc=tom@talpey.com \
--cc=yoonho.shin@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox