From: Paulo Alcantara <pc@manguebit.org>
To: NeilBrown <neil@brown.name>, Namjae Jeon <linkinjeon@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>
Cc: Jeff Layton <jlayton@kernel.org>, Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-cifs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] smb/client(cifs): prepare for VFS locking changes.
Date: Thu, 22 Oct 2026 21:03:53 -0300 [thread overview]
Message-ID: <1d601486a9c3fa0045306a1cd031cf8a@manguebit.org> (raw)
In-Reply-To: <20260929024352.1433257-1-neilb@ownmail.net>
NeilBrown <neilb@ownmail.net> writes:
> The previous version of this series had a couple of problems reported by sashiko,
> both in 2/3.
> 1/ an error from cifs_lookup() wasn't handled properly - it should be fatal
> 2/ The d_is_positive() tested the wrong dentry.
>
> Original intro message below.
> Thanks,
> NeilBrown
>
>
> I am working on changes to directory locking. The medium term goal is
> to lift d_alloc_parallel() locking above i_rwsem, so d_alloc_paralle()
> can be run unlocked, and consequently cannot be called when ->i_rwsem is
> held.
>
> The requires:
> 1/ that d_alloc_parallel() not be called while i_rwsem is held. cifs
> does this in a couple of places. A new interface d_alloc_trylock()
> is now available and can be used instead.
>
> 2/ a dentry must not be d_drop()ed while an operation is ongoing, as an
> unlocked d_alloc_parallel() would then be able to create a new
> dentry with the same name. In particular d_rehash() must be phased
> out as it won't be safe. This particularly affects the mechanism to
> block lookups/revalidates while an unlink/rename is happening. The
> mechanism is changed to use one similar to how NFS addresses this
> needed, though using the new LOOKUP_PRIVATE flag.
>
> The patches depend on patches recently added to the vfs tree. I would
> prefer these land in that tree too with an Acked-by or similar from cifs
> maintainers.
> ...
LGTM. Thanks Neil.
Acked-by: Paulo Alcantara <pc@manguebit.org>
Christian, feel free take it through vfs tree.
prev parent reply other threads:[~2026-10-23 0:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 2:40 [PATCH v2 0/3] smb/client(cifs): prepare for VFS locking changes NeilBrown
2026-09-29 2:40 ` [PATCH v2 1/3] smb/client: don't unhash and rehash to prevent new opens NeilBrown
2026-09-29 2:40 ` [PATCH v2 2/3] smb/client: use d_alloc_trylock in cifs_silly_fullpath() NeilBrown
2026-09-29 2:40 ` [PATCH v2 3/3] smb/client: Use d_alloc_trylock() in cifs_prime_dcache() NeilBrown
2026-10-23 0:02 ` Paulo Alcantara
2026-10-23 1:32 ` NeilBrown
2026-10-21 13:43 ` [PATCH v2 0/3] smb/client(cifs): prepare for VFS locking changes Namjae Jeon
2026-10-23 0:03 ` Paulo Alcantara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d601486a9c3fa0045306a1cd031cf8a@manguebit.org \
--to=pc@manguebit.org \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil@brown.name \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox