From: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 6/6] cifs: add separate cred_uid field to sesInfo
Date: Thu, 15 Jul 2010 17:19:36 -0400 [thread overview]
Message-ID: <20100715171936.4252a16d@corrin.poochiereds.net> (raw)
In-Reply-To: <AANLkTik7vm4iYcRH2oGxuINyL2VxY_h9Y03sFhQWR19d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, 15 Jul 2010 15:24:46 -0500
Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> I merged the first 5 of this series, but wanted to understand what
> behavior this changes first (it is probably ok). With current
> userspace code - what changes would a user see with this?
>
With this and the accompanying userspace patch, this makes it so that
the credentials cache used when mounting with sec=krb5 is unaffected by
the uid= option. The credcache will be determined using the real uid of
the user performing the mount. There will be a cifs.upcall option that
will make it use the legacy behavior for those that require it for some
reason.
I consider the current situation a bad design decision on my part as
the ownership of files on the mount has no direct relationship to the
owner of the mount credentials. The mount credentials should always be
under the ownership of the user performing the mount. The existing
scheme allows someone to use the credcache of another user to perform
a mount.
I'll resend the userspace patch in another day or two when I get back
from vacation.
--
Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
next prev parent reply other threads:[~2010-07-15 21:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-20 21:10 [PATCH 0/6] cifs: session matching and authentication fixes and cleanups Jeff Layton
[not found] ` <1277068251-16344-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-06-20 21:10 ` [PATCH 1/6] cifs: have cifs_convert_address set port Jeff Layton
2010-06-20 21:10 ` [PATCH 2/6] cifs: move address comparison into separate function Jeff Layton
2010-06-20 21:10 ` [PATCH 3/6] cifs: match secType when searching for existing tcp session Jeff Layton
2010-06-20 21:10 ` [PATCH 4/6] cifs: clean up cifs_find_smb_ses Jeff Layton
2010-06-20 21:10 ` [PATCH 5/6] cifs: remove unused cifsUidInfo struct Jeff Layton
2010-06-20 21:10 ` [PATCH 6/6] cifs: add separate cred_uid field to sesInfo Jeff Layton
[not found] ` <1277068251-16344-7-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-07-15 20:24 ` Steve French
[not found] ` <AANLkTik7vm4iYcRH2oGxuINyL2VxY_h9Y03sFhQWR19d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-07-15 21:19 ` Jeff Layton [this message]
[not found] ` <20100715171936.4252a16d-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2010-07-18 11:18 ` Jeff Layton
[not found] ` <20100718071819.4264e8aa-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2010-07-23 20:51 ` Jeff Layton
2010-07-23 18:41 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100715171936.4252a16d@corrin.poochiereds.net \
--to=jlayton-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox