From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 01/15] cifs: eliminate redundant xdev check in cifs_rename
Date: Wed, 25 Aug 2010 13:59:52 -0400 [thread overview]
Message-ID: <20100825175952.GA27774@infradead.org> (raw)
In-Reply-To: <AANLkTikVRKBA-sv3F8cJMFV3nfqfu4AYXXJ9E4Ja+Qv+-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Wed, Aug 25, 2010 at 11:34:07AM -0500, Steve French wrote:
> On Fri, Aug 20, 2010 at 2:31 PM, Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> > The VFS always checks that the source and target of a rename are on the
> > same vfsmount, and hence have the same superblock. So, this check is
> > redundant. Remove it and simplify the error handling.
>
> I looked more closely at this, and although EXDEV is checked for in one
> place (early in the rename syscall), there are other paths to iop->cifs_rename
> (nfs server and cachefiles for example call vfs_rename directly)
> which do not check this, so it looks like the cifs EXDEV check
> is not redundant and should be kept.
If ->rename evers gets called with dentries on different superblocks
hell would break lose. nfsd also explicitly checks for it,
and in cachefiles it can't happen because we do a lookup_one_len
on the local fs for the target. Note that these cases matter for
cifs anyway given that it doesn't provide export ops.
There is no need to keep this junk around.
next prev parent reply other threads:[~2010-08-25 17:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 19:31 [PATCH 00/15] cifs: multiuser mount overhaul (try #3) Jeff Layton
2010-08-20 19:31 ` [PATCH 01/15] cifs: eliminate redundant xdev check in cifs_rename Jeff Layton
[not found] ` <1282332731-17444-2-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-08-25 16:34 ` Steve French
[not found] ` <AANLkTikVRKBA-sv3F8cJMFV3nfqfu4AYXXJ9E4Ja+Qv+-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-08-25 17:55 ` Jeff Layton
2010-08-25 17:59 ` Christoph Hellwig [this message]
2010-08-20 19:31 ` [PATCH 02/15] cifs: add tcon field to cifsFileInfo struct Jeff Layton
2010-08-20 19:32 ` [PATCH 04/15] cifs: fix handling of signing with writepages Jeff Layton
2010-08-20 19:32 ` [PATCH 06/15] cifs: temporarily rename cifs_sb->tcon to ptcon to catch stragglers Jeff Layton
2010-08-20 19:32 ` [PATCH 08/15] cifs: have cifs_new_fileinfo take a tcon arg Jeff Layton
2010-08-20 19:32 ` [PATCH 10/15] cifs: have cifsFileInfo hold a reference to a tlink rather than tcon pointer Jeff Layton
2010-08-20 19:32 ` [PATCH 11/15] cifs: have find_readable/writable_file filter by fsuid Jeff Layton
2010-08-20 19:32 ` [PATCH 12/15] cifs: fix cifs_show_options to show "username=" or "multiuser" Jeff Layton
2010-08-20 19:32 ` [PATCH 13/15] cifs: add routines to build sessions and tcons on the fly Jeff Layton
[not found] ` <1282332731-17444-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-08-20 19:31 ` [PATCH 03/15] cifs: make various routines use the cifsFileInfo->tcon pointer Jeff Layton
2010-08-20 19:32 ` [PATCH 05/15] cifs: add function to get a tcon from cifs_sb Jeff Layton
2010-08-20 19:32 ` [PATCH 07/15] cifs: add cifs_sb_master_tcon and convert some callers to use it Jeff Layton
2010-08-20 19:32 ` [PATCH 09/15] cifs: add refcounted and timestamped container for holding tcons Jeff Layton
2010-08-20 19:32 ` [PATCH 14/15] cifs: on multiuser mount, set ownership to current_fsuid/current_fsgid Jeff Layton
2010-08-20 19:32 ` [PATCH 15/15] cifs: add "multiuser" mount option Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100825175952.GA27774@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).