From: Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
To: shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH -v2 0/6] ntlmv2 within ntlmssp - enable and sign using crypto apis
Date: Sun, 12 Sep 2010 20:27:01 -0400 [thread overview]
Message-ID: <20100912202701.1cd7d8bf@corrin.poochiereds.net> (raw)
In-Reply-To: <1284056215-959-1-git-send-email-shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Thu, 9 Sep 2010 13:16:55 -0500
shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> Three major functionality changes
>
Maybe this should be 3 separate patchsets then? It would be best if
these major functionality changes were bisectable. Also, these patches
mix a lot of trivial cleanup code in with the deltas that actually make
the major changes. Those should be separated.
IOW, more patches that are smaller and targeted would be ideal.
>
> Make NTLMv2 as a default authentication mechanism within NTLMSSP
>
> Enable cifs/smb signing
>
> Use Crypto sync hash APIs instead of cifs crypto functions to genereate
> various hashes such as arc4/rc4, md5, and hmac-md5 used during authentication
> and smb/cifs signature generation
>
It seems like this set should be a net reduction in code or at least
something closer to 0. This set should not be merged without an
accompanying patch to remove the unused crypto code after the
conversion to the kernel crypto APIs.
--
Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
next prev parent reply other threads:[~2010-09-13 0:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 18:16 [PATCH -v2 0/6] ntlmv2 within ntlmssp - enable and sign using crypto apis shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <1284056215-959-1-git-send-email-shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-09-13 0:27 ` Jeff Layton [this message]
[not found] ` <20100912202701.1cd7d8bf-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2010-09-13 2:03 ` Shirish Pargaonkar
2010-09-13 10:27 ` Shirish Pargaonkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100912202701.1cd7d8bf@corrin.poochiereds.net \
--to=jlayton-eunubhrolfbytjvyw6ydsg@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox